Netdev Archive on lore.kernel.org help / color / mirror / Atom feed
From: Dongdong Liu <liudongdong3@huawei.com> To: <helgaas@kernel.org>, <hch@infradead.org>, <kw@linux.com>, <logang@deltatee.com>, <leon@kernel.org>, <linux-pci@vger.kernel.org>, <rajur@chelsio.com>, <hverkuil-cisco@xs4all.nl> Cc: <linux-media@vger.kernel.org>, <netdev@vger.kernel.org> Subject: [PATCH V7 7/9] PCI/sysfs: Add a 10-Bit Tag sysfs file Date: Wed, 4 Aug 2021 21:47:06 +0800 [thread overview] Message-ID: <1628084828-119542-8-git-send-email-liudongdong3@huawei.com> (raw) In-Reply-To: <1628084828-119542-1-git-send-email-liudongdong3@huawei.com> PCIe spec 5.0 r1.0 section 2.2.6.2 says that if an Endpoint supports sending Requests to other Endpoints (as opposed to host memory), the Endpoint must not send 10-Bit Tag Requests to another given Endpoint unless an implementation-specific mechanism determines that the Endpoint supports 10-Bit Tag Completer capability. Add a 10bit_tag sysfs file, write 0 to disable 10-Bit Tag Requester when the driver does not bind the device if the peer device does not support the 10-Bit Tag Completer. This will make P2P traffic safe. the 10bit_tag file content indicate current 10-Bit Tag Requester Enable status. Signed-off-by: Dongdong Liu <liudongdong3@huawei.com> --- Documentation/ABI/testing/sysfs-bus-pci | 16 +++++++- drivers/pci/pci-sysfs.c | 69 +++++++++++++++++++++++++++++++++ 2 files changed, 84 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-bus-pci b/Documentation/ABI/testing/sysfs-bus-pci index 793cbb7..0e0c97d 100644 --- a/Documentation/ABI/testing/sysfs-bus-pci +++ b/Documentation/ABI/testing/sysfs-bus-pci @@ -139,7 +139,7 @@ Description: binary file containing the Vital Product Data for the device. It should follow the VPD format defined in PCI Specification 2.1 or 2.2, but users should consider - that some devices may have incorrectly formatted data. + that some devices may have incorrectly formatted data. If the underlying VPD has a writable section then the corresponding section of this file will be writable. @@ -407,3 +407,17 @@ Description: The file is writable if the PF is bound to a driver that implements ->sriov_set_msix_vec_count(). + +What: /sys/bus/pci/devices/.../10bit_tag +Date: August 2021 +Contact: Dongdong Liu <liudongdong3@huawei.com> +Description: + If a PCI device support 10-Bit Tag Requester, will create the + 10bit_tag sysfs file. The file is readable, the value + indicate current 10-Bit Tag Requester Enable. + 1 - enabled, 0 - disabled. + + The file is also writeable, the value only accept by write 0 + to disable 10-Bit Tag Requester when the driver does not bind + the deivce. The typical use case is for p2pdma when the peer + device does not support 10-BIT Tag Completer. diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 5d63df7..e93ce8b 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -306,6 +306,49 @@ static ssize_t enable_show(struct device *dev, struct device_attribute *attr, } static DEVICE_ATTR_RW(enable); +static ssize_t pci_10bit_tag_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct pci_dev *pdev = to_pci_dev(dev); + bool enable; + + if (kstrtobool(buf, &enable) < 0) + return -EINVAL; + + if (enable != false ) + return -EINVAL; + + if (pdev->driver) + return -EBUSY; + + pcie_capability_clear_word(pdev, PCI_EXP_DEVCTL2, + PCI_EXP_DEVCTL2_10BIT_TAG_REQ_EN); + pci_info(pdev, "disabled 10-Bit Tag Requester\n"); + + return count; +} + +static ssize_t pci_10bit_tag_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct pci_dev *pdev = to_pci_dev(dev); + u16 ctl; + int ret; + + ret = pcie_capability_read_word(pdev, PCI_EXP_DEVCTL2, &ctl); + if (ret) + return -EINVAL; + + return sysfs_emit(buf, "%u\n", + !!(ctl & PCI_EXP_DEVCTL2_10BIT_TAG_REQ_EN)); +} + +static struct device_attribute dev_attr_10bit_tag = __ATTR(10bit_tag, 0600, + pci_10bit_tag_show, + pci_10bit_tag_store); + #ifdef CONFIG_NUMA static ssize_t numa_node_store(struct device *dev, struct device_attribute *attr, const char *buf, @@ -635,6 +678,11 @@ static struct attribute *pcie_dev_attrs[] = { NULL, }; +static struct attribute *pcie_dev_10bit_tag_attrs[] = { + &dev_attr_10bit_tag.attr, + NULL, +}; + static struct attribute *pcibus_attrs[] = { &dev_attr_bus_rescan.attr, &dev_attr_cpuaffinity.attr, @@ -1482,6 +1530,21 @@ static umode_t pcie_dev_attrs_are_visible(struct kobject *kobj, return 0; } +static umode_t pcie_dev_10bit_tag_attrs_are_visible(struct kobject *kobj, + struct attribute *a, int n) +{ + struct device *dev = kobj_to_dev(kobj); + struct pci_dev *pdev = to_pci_dev(dev); + + if (pdev->is_virtfn) + return 0; + + if (!(pdev->pcie_devcap2 & PCI_EXP_DEVCAP2_10BIT_TAG_REQ)) + return 0; + + return a->mode; +} + static const struct attribute_group pci_dev_group = { .attrs = pci_dev_attrs, }; @@ -1521,6 +1584,11 @@ static const struct attribute_group pcie_dev_attr_group = { .is_visible = pcie_dev_attrs_are_visible, }; +static const struct attribute_group pcie_dev_10bit_tag_attr_group = { + .attrs = pcie_dev_10bit_tag_attrs, + .is_visible = pcie_dev_10bit_tag_attrs_are_visible, +}; + static const struct attribute_group *pci_dev_attr_groups[] = { &pci_dev_attr_group, &pci_dev_hp_attr_group, @@ -1530,6 +1598,7 @@ static const struct attribute_group *pci_dev_attr_groups[] = { #endif &pci_bridge_attr_group, &pcie_dev_attr_group, + &pcie_dev_10bit_tag_attr_group, #ifdef CONFIG_PCIEAER &aer_stats_attr_group, #endif -- 2.7.4
next prev parent reply other threads:[~2021-08-04 13:49 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-04 13:46 [PATCH V7 0/9] PCI: Enable 10-Bit tag support for PCIe devices Dongdong Liu 2021-08-04 13:47 ` [PATCH V7 1/9] PCI: Use cached Device Capabilities Register Dongdong Liu 2021-08-04 13:47 ` [PATCH V7 2/9] PCI: Use cached Device Capabilities 2 Register Dongdong Liu 2021-08-04 13:47 ` [PATCH V7 3/9] PCI: Add 10-Bit Tag register definitions Dongdong Liu 2021-08-04 13:47 ` [PATCH V7 4/9] PCI: Enable 10-Bit Tag support for PCIe Endpoint devices Dongdong Liu 2021-08-04 23:17 ` Bjorn Helgaas 2021-08-05 7:47 ` Dongdong Liu 2021-08-05 19:54 ` Bjorn Helgaas 2021-08-07 6:19 ` Dongdong Liu 2021-08-04 13:47 ` [PATCH V7 5/9] PCI/IOV: Enable 10-Bit tag support for PCIe VF devices Dongdong Liu 2021-08-04 23:29 ` Bjorn Helgaas 2021-08-05 8:03 ` Dongdong Liu 2021-08-06 22:59 ` Bjorn Helgaas 2021-08-07 7:46 ` Dongdong Liu 2021-08-04 13:47 ` [PATCH V7 6/9] PCI: Enable 10-Bit Tag support for PCIe RP devices Dongdong Liu 2021-08-04 23:38 ` Bjorn Helgaas 2021-08-05 8:25 ` Dongdong Liu 2021-08-09 17:26 ` Bjorn Helgaas 2021-08-10 11:59 ` Dongdong Liu 2021-08-04 13:47 ` Dongdong Liu [this message] 2021-08-04 15:51 ` [PATCH V7 7/9] PCI/sysfs: Add a 10-Bit Tag sysfs file Logan Gunthorpe 2021-08-05 13:14 ` Dongdong Liu 2021-08-05 13:53 ` Leon Romanovsky 2021-08-05 15:36 ` Logan Gunthorpe 2021-08-04 23:49 ` Bjorn Helgaas 2021-08-05 8:37 ` Dongdong Liu 2021-08-05 15:31 ` Bjorn Helgaas 2021-08-07 7:01 ` Dongdong Liu 2021-08-09 17:37 ` Bjorn Helgaas 2021-08-10 12:16 ` Dongdong Liu 2021-08-04 23:52 ` Bjorn Helgaas 2021-08-05 8:38 ` Dongdong Liu 2021-08-04 13:47 ` [PATCH V7 8/9] PCI/IOV: Add 10-Bit Tag sysfs files for VF devices Dongdong Liu 2021-08-05 0:05 ` Bjorn Helgaas 2021-08-05 8:47 ` Dongdong Liu 2021-08-05 9:39 ` Dongdong Liu 2021-08-04 13:47 ` [PATCH V7 9/9] PCI/P2PDMA: Add a 10-Bit Tag check in P2PDMA Dongdong Liu 2021-08-04 15:56 ` Logan Gunthorpe 2021-08-05 8:49 ` Dongdong Liu 2021-08-05 18:12 ` Bjorn Helgaas 2021-08-07 7:11 ` Dongdong Liu 2021-08-09 17:31 ` Bjorn Helgaas 2021-08-10 12:31 ` Dongdong Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1628084828-119542-8-git-send-email-liudongdong3@huawei.com \ --to=liudongdong3@huawei.com \ --cc=hch@infradead.org \ --cc=helgaas@kernel.org \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kw@linux.com \ --cc=leon@kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=logang@deltatee.com \ --cc=netdev@vger.kernel.org \ --cc=rajur@chelsio.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).