Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v1 net 1/1] ptp_pch: Restore dependency on PCI
@ 2021-08-13 17:33 Andy Shevchenko
2021-08-13 21:34 ` Jakub Kicinski
2021-08-16 10:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-08-13 17:33 UTC (permalink / raw)
To: Richard Cochran, Jonathan Lemon, netdev, linux-kernel
Cc: Andy Shevchenko, kernel test robot
During the swap dependency on PCH_GBE to selection PTP_1588_CLOCK_PCH
incidentally dropped the implicit dependency on the PCI. Restore it.
Fixes: 18d359ceb044 ("pch_gbe, ptp_pch: Fix the dependency direction between these drivers")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/ptp/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index 8c20e524e9ad..e085c255da0c 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -90,7 +90,8 @@ config PTP_1588_CLOCK_INES
config PTP_1588_CLOCK_PCH
tristate "Intel PCH EG20T as PTP clock"
depends on X86_32 || COMPILE_TEST
- depends on HAS_IOMEM && NET
+ depends on HAS_IOMEM && PCI
+ depends on NET
imply PTP_1588_CLOCK
help
This driver adds support for using the PCH EG20T as a PTP
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 net 1/1] ptp_pch: Restore dependency on PCI
2021-08-13 17:33 [PATCH v1 net 1/1] ptp_pch: Restore dependency on PCI Andy Shevchenko
@ 2021-08-13 21:34 ` Jakub Kicinski
2021-08-16 10:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-08-13 21:34 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Richard Cochran, Jonathan Lemon, netdev, linux-kernel, kernel test robot
On Fri, 13 Aug 2021 20:33:27 +0300 Andy Shevchenko wrote:
> During the swap dependency on PCH_GBE to selection PTP_1588_CLOCK_PCH
> incidentally dropped the implicit dependency on the PCI. Restore it.
>
> Fixes: 18d359ceb044 ("pch_gbe, ptp_pch: Fix the dependency direction between these drivers")
It was breaking build for 9 years and nobody hit it?
What's the build failure?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 net 1/1] ptp_pch: Restore dependency on PCI
2021-08-13 17:33 [PATCH v1 net 1/1] ptp_pch: Restore dependency on PCI Andy Shevchenko
2021-08-13 21:34 ` Jakub Kicinski
@ 2021-08-16 10:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-16 10:30 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: richardcochran, jonathan.lemon, netdev, linux-kernel, lkp
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 13 Aug 2021 20:33:27 +0300 you wrote:
> During the swap dependency on PCH_GBE to selection PTP_1588_CLOCK_PCH
> incidentally dropped the implicit dependency on the PCI. Restore it.
>
> Fixes: 18d359ceb044 ("pch_gbe, ptp_pch: Fix the dependency direction between these drivers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> [...]
Here is the summary with links:
- [v1,net,1/1] ptp_pch: Restore dependency on PCI
https://git.kernel.org/netdev/net/c/55c8fca1dae1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-16 10:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-13 17:33 [PATCH v1 net 1/1] ptp_pch: Restore dependency on PCI Andy Shevchenko
2021-08-13 21:34 ` Jakub Kicinski
2021-08-16 10:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).