Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] stmmac: dwmac-loongson:Fix missing return value
@ 2021-09-06  7:21 zhaoxiao
  2021-09-06 12:24 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: zhaoxiao @ 2021-09-06  7:21 UTC (permalink / raw)
  To: davem, kuba, mcoquelin.stm32
  Cc: peppe.cavallaro, alexandre.torgue, joabreu, netdev, linux-stm32,
	linux-arm-kernel, linux-kernel, zhaoxiao

Add the return value when phy_mode < 0.

Signed-off-by: zhaoxiao <long870912@gmail.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
index 4c9a37dd0d3f..ecf759ee1c9f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
@@ -109,8 +109,10 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
 		plat->bus_id = pci_dev_id(pdev);
 
 	phy_mode = device_get_phy_mode(&pdev->dev);
-	if (phy_mode < 0)
+	if (phy_mode < 0) {
 		dev_err(&pdev->dev, "phy_mode not found\n");
+		return phy_mode;
+	}
 
 	plat->phy_interface = phy_mode;
 	plat->interface = PHY_INTERFACE_MODE_GMII;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] stmmac: dwmac-loongson:Fix missing return value
  2021-09-06  7:21 [PATCH] stmmac: dwmac-loongson:Fix missing return value zhaoxiao
@ 2021-09-06 12:24 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-06 12:24 UTC (permalink / raw)
  To: zhaoxiao
  Cc: davem, kuba, mcoquelin.stm32, peppe.cavallaro, alexandre.torgue,
	joabreu, netdev, linux-stm32, linux-arm-kernel, linux-kernel

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon,  6 Sep 2021 15:21:07 +0800 you wrote:
> Add the return value when phy_mode < 0.
> 
> Signed-off-by: zhaoxiao <long870912@gmail.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Here is the summary with links:
  - stmmac: dwmac-loongson:Fix missing return value
    https://git.kernel.org/netdev/net/c/5289de5929d1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-06 12:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-06  7:21 [PATCH] stmmac: dwmac-loongson:Fix missing return value zhaoxiao
2021-09-06 12:24 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).