Netdev Archive on
help / color / mirror / Atom feed
To: Yoshihiro Shimoda <>
Subject: Re: [PATCH] net: renesas: sh_eth: Fix freeing wrong tx descriptor
Date: Tue, 07 Sep 2021 13:10:06 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


This patch was applied to netdev/net.git (refs/heads/master):

On Tue,  7 Sep 2021 20:29:40 +0900 you wrote:
> The cur_tx counter must be incremented after TACT bit of
> txdesc->status was set. However, a CPU is possible to reorder
> instructions and/or memory accesses between cur_tx and
> txdesc->status. And then, if TX interrupt happened at such a
> timing, the sh_eth_tx_free() may free the descriptor wrongly.
> So, add wmb() before cur_tx++.
> Otherwise NETDEV WATCHDOG timeout is possible to happen.
> [...]

Here is the summary with links:
  - net: renesas: sh_eth: Fix freeing wrong tx descriptor

You are awesome, thank you!
Deet-doot-dot, I am a bot.

  reply	other threads:[~2021-09-07 13:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 11:29 Yoshihiro Shimoda
2021-09-07 13:10 ` patchwork-bot+netdevbpf [this message]
2021-09-07 19:29 ` Sergey Shtylyov
2021-09-08  5:45   ` Yoshihiro Shimoda
2021-09-08  9:46     ` Sergey Shtylyov
2021-09-08 11:43       ` Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] net: renesas: sh_eth: Fix freeing wrong tx descriptor' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).