Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Wen Gu <guwen@linux.alibaba.com>
To: kgraul@linux.ibm.com, davem@davemloft.net, kuba@kernel.org
Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH net 0/3] net/smc: Fixes for race in smc link group termination
Date: Mon, 10 Jan 2022 17:26:21 +0800	[thread overview]
Message-ID: <1641806784-93141-1-git-send-email-guwen@linux.alibaba.com> (raw)

We encountered some crashes recently and they are caused by the
race between the access and free of link/link group in abnormal
smc link group termination. The crashes can be reproduced in
frequent abnormal link group termination, like setting RNICs up/down.

This set of patches tries to fix this by extending the life cycle
of link/link group to ensure that they won't be referred to after
cleared or freed.

Wen Gu (3):
  net/smc: Resolve the race between link group access and termination
  net/smc: Introduce a new conn->lgr validity check helper
  net/smc: Resolve the race between SMC-R link access and clear

 net/smc/af_smc.c   |  6 +++-
 net/smc/smc.h      |  1 +
 net/smc/smc_cdc.c  |  3 +-
 net/smc/smc_clc.c  |  2 +-
 net/smc/smc_core.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++--------
 net/smc/smc_core.h | 12 +++++++
 net/smc/smc_diag.c |  6 ++--
 7 files changed, 104 insertions(+), 20 deletions(-)

-- 
1.8.3.1


             reply	other threads:[~2022-01-10  9:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10  9:26 Wen Gu [this message]
2022-01-10  9:26 ` [PATCH net 1/3] net/smc: Resolve the race between link group access and termination Wen Gu
2022-01-10 12:25   ` Karsten Graul
2022-01-10 13:56     ` Wen Gu
2022-01-11  8:23   ` Karsten Graul
2022-01-11 15:36     ` Wen Gu
2022-01-11 15:46       ` Karsten Graul
2022-01-11 15:51         ` Wen Gu
2022-01-10  9:26 ` [PATCH net 2/3] net/smc: Introduce a new conn->lgr validity check helper Wen Gu
2022-01-10  9:26 ` [PATCH net 3/3] net/smc: Resolve the race between SMC-R link access and clear Wen Gu
2022-01-11  8:40   ` Karsten Graul
2022-01-11 15:49     ` Wen Gu
2022-01-11 16:02       ` Karsten Graul
2022-01-11 16:44         ` Wen Gu
2022-01-11 17:42           ` Karsten Graul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1641806784-93141-1-git-send-email-guwen@linux.alibaba.com \
    --to=guwen@linux.alibaba.com \
    --cc=davem@davemloft.net \
    --cc=kgraul@linux.ibm.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net 0/3] net/smc: Fixes for race in smc link group termination' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).