Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Parav Pandit <parav@nvidia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"dsahern@kernel.org" <dsahern@kernel.org>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>
Cc: Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH iproute2-next] devlink: Show port state values in man page and in the help command
Date: Tue, 10 Aug 2021 07:18:11 -0600	[thread overview]
Message-ID: <1b476bdd-dc87-4ddf-08b1-e2aaf7cca7f6@gmail.com> (raw)
In-Reply-To: <PH0PR12MB5481796816B64C41F8230E0ADCF79@PH0PR12MB5481.namprd12.prod.outlook.com>

On 8/10/21 5:49 AM, Parav Pandit wrote:
> Hi David, Stephen,
> 
>> From: Parav Pandit <parav@nvidia.com>
>> Sent: Friday, July 23, 2021 8:24 PM
>>
>> Port function state can have either of the two values - active or inactive.
>> Update the documentation and help command for these two values to tell
>> user about it.
>>
>> With the introduction of state, hw_addr and state are optional.
>> Hence mark them as optional in man page that also aligns with the help
>> command output.
>>
>> Fixes: bdfb9f1bd61a ("devlink: Support set of port function state")
>> Signed-off-by: Parav Pandit <parav@nvidia.com>
>> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
>> ---
>>  devlink/devlink.c       |  2 +-
>>  man/man8/devlink-port.8 | 10 +++++-----
>>  2 files changed, 6 insertions(+), 6 deletions(-)
>>
> Can you please review this short fix?
> 

It is assigned to Stephen, but some how marked as 'archived'. I removed
that label and it is back in Stephen's list.

  reply	other threads:[~2021-08-10 13:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 14:53 Parav Pandit
2021-08-10 11:49 ` Parav Pandit
2021-08-10 13:18   ` David Ahern [this message]
2021-08-10 13:19     ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b476bdd-dc87-4ddf-08b1-e2aaf7cca7f6@gmail.com \
    --to=dsahern@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=jiri@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=parav@nvidia.com \
    --cc=stephen@networkplumber.org \
    --subject='Re: [PATCH iproute2-next] devlink: Show port state values in man page and in the help command' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).