Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
	syzbot <syzbot+8a5dadc5c0b1d7055945@syzkaller.appspotmail.com>,
	ast@kernel.org, bpf@vger.kernel.org, john.fastabend@gmail.com,
	kafai@fb.com, kpsingh@chromium.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, songliubraving@fb.com,
	syzkaller-bugs@googlegroups.com, yhs@fb.com
Subject: Re: WARNING in bpf_cgroup_link_release
Date: Thu, 16 Apr 2020 13:26:12 +0300	[thread overview]
Message-ID: <20200416102612.GO1163@kadam> (raw)
In-Reply-To: <a9219326-c07c-1069-270c-4bef17ee7b88@fb.com>

On Wed, Apr 15, 2020 at 09:51:40AM -0700, 'Andrii Nakryiko' via syzkaller-bugs wrote:
> On 4/15/20 4:57 AM, Daniel Borkmann wrote:
> > On 4/15/20 8:55 AM, syzbot wrote:
> > > Hello,
> > > 
> > > syzbot found the following crash on:
> > 
> > Andrii, ptal.
> > 
> > > HEAD commit:    1a323ea5 x86: get rid of 'errret' argument to
> > > __get_user_x..
> > > git tree:       bpf-next
> > > console output: https://urldefense.proofpoint.com/v2/url?u=https-3A__syzkaller.appspot.com_x_log.txt-3Fx-3D148ccb57e00000&d=DwICaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=vxqvl81C2rT6GOGdPyz8iQ&m=T2Ez0XmyIpHmEa_MPTTUOh61jMDXqwETtTaTbSe-2M4&s=-6XBbsNV1O4X5flrx4Yssfjc56d0qeSHgwHhd92UPJc&e=
> > > kernel config:  https://urldefense.proofpoint.com/v2/url?u=https-3A__syzkaller.appspot.com_x_.config-3Fx-3D8c1e98458335a7d1&d=DwICaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=vxqvl81C2rT6GOGdPyz8iQ&m=T2Ez0XmyIpHmEa_MPTTUOh61jMDXqwETtTaTbSe-2M4&s=s5-1AlWtSiBvo66WN4_UXoXMGIGIqsoUCrmAnxNnfX0&e=
> > > dashboard link: https://urldefense.proofpoint.com/v2/url?u=https-3A__syzkaller.appspot.com_bug-3Fextid-3D8a5dadc5c0b1d7055945&d=DwICaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=vxqvl81C2rT6GOGdPyz8iQ&m=T2Ez0XmyIpHmEa_MPTTUOh61jMDXqwETtTaTbSe-2M4&s=hAA0702qJH5EwRwvG0RKmj8FwIRm1O8hvmoS7ne5Dls&e=
> > > compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
> > > 
> > > Unfortunately, I don't have any reproducer for this crash yet.
> > > 
> > > IMPORTANT: if you fix the bug, please add the following tag to the
> > > commit:
> > > Reported-by: syzbot+8a5dadc5c0b1d7055945@syzkaller.appspotmail.com
> > > 
> > > ------------[ cut here ]------------
> > > WARNING: CPU: 0 PID: 25081 at kernel/bpf/cgroup.c:796
> > > bpf_cgroup_link_release+0x260/0x3a0 kernel/bpf/cgroup.c:796
> 
> This warning is triggered due to __cgroup_bpf_detach returning an error. It
> can do it only in two cases: either attached item is not found, which from
> starting at code some moreI don't see how that can happen. The other reason
> - kmalloc() failing to allocate memory for new effective prog array.

If you look at the log file then this was allocation fault injection in
bpf_prog_array_alloc().

https://syzkaller.appspot.com/x/log.txt?x=148ccb57e00000

regards,
dan carpenter


  reply	other threads:[~2020-04-16 10:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15  6:55 syzbot
2020-04-15 11:57 ` Daniel Borkmann
2020-04-15 16:51   ` Andrii Nakryiko
2020-04-16 10:26     ` Dan Carpenter [this message]
2020-04-16 19:47       ` Andrii Nakryiko
2020-09-01  2:58 ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200416102612.GO1163@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=syzbot+8a5dadc5c0b1d7055945@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=yhs@fb.com \
    --subject='Re: WARNING in bpf_cgroup_link_release' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).