Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Helmut Grohne <helmut.grohne@intenta.de>
Cc: Woojung Huh <woojung.huh@microchip.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH] net: dsa: microchip: delete dead code
Date: Sat, 25 Jul 2020 19:41:30 +0200	[thread overview]
Message-ID: <20200725174130.GL1472201@lunn.ch> (raw)
In-Reply-To: <20200723042431.GA14746@laureti-dev>

On Thu, Jul 23, 2020 at 06:24:31AM +0200, Helmut Grohne wrote:
> Hi Andrew,
> 
> On Wed, Jul 22, 2020 at 04:39:53PM +0200, Andrew Lunn wrote:
> > This patch probably is correct. But it is not obviously correct,
> > because there are so many changes at once. Please could you break it
> > up.
> 
> >From my pov, it is less a question of whether it is correct, but whether
> it goes into the desired direction. There are a few comments in the
> driver that point to pending work. It might as well be that I'm removing
> the infrastructure that other patches are meant to build upon.

Hi Helmut

There was a small burst of patches from Microchip in this month. But
apart from that, you need to go a long way back.

I say clean it up now. The code is in the git history, so it is easy
to get back if needed.

   Andrew

  reply	other threads:[~2020-07-25 17:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21  8:33 Helmut Grohne
2020-07-22 14:39 ` Andrew Lunn
2020-07-23  4:24   ` Helmut Grohne
2020-07-25 17:41     ` Andrew Lunn [this message]
2020-08-17 14:55       ` [PATCH v2 0/6] " Helmut Grohne
2020-08-17 14:55         ` [PATCH v2 1/6] net: dsa: microchip: delete unused member ksz_port.phy Helmut Grohne
2020-08-17 14:55         ` [PATCH v2 2/6] net: dsa: microchip: delete unused member ksz_port.sgmii Helmut Grohne
2020-08-17 14:55         ` [PATCH v2 3/6] net: dsa: microchip: delete unused member ksz_port.force Helmut Grohne
2020-08-17 14:55         ` [PATCH v2 4/6] net: dsa: microchip: delete unused member ksz_device.last_port Helmut Grohne
2020-08-17 14:59         ` [PATCH v2 5/6] net: dsa: microchip: delete unused member ksz_device.regs_size Helmut Grohne
2020-08-17 14:59         ` [PATCH v2 6/6] net: dsa: microchip: delete unused member ksz_device.overrides Helmut Grohne
2020-08-17 15:18         ` [PATCH v2 0/6] net: dsa: microchip: delete dead code Florian Fainelli
2020-08-18  7:57           ` Helmut Grohne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200725174130.GL1472201@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=helmut.grohne@intenta.de \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    --cc=woojung.huh@microchip.com \
    --subject='Re: [RFC PATCH] net: dsa: microchip: delete dead code' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).