Netdev Archive on
help / color / mirror / Atom feed
From: Dan Carpenter <>
To: Saeed Mahameed <>,
	"Gustavo A. R. Silva" <>
Cc: Leon Romanovsky <>,
	"David S. Miller" <>,
	Jakub Kicinski <>,,,
Subject: [PATCH net-next] net/mlx5: remove erroneous fallthrough
Date: Mon, 3 Aug 2020 17:34:48 +0300	[thread overview]
Message-ID: <20200803143448.GA346925@mwanda> (raw)

This isn't a fall through because it was after a return statement.  The
fall through annotation leads to a Smatch warning:

    mlx5e_ethtool_get_sset_count() warn: ignoring unreachable code.

Signed-off-by: Dan Carpenter <>
 drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
index 08270987c506..48397a577fcd 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
@@ -243,7 +243,6 @@ int mlx5e_ethtool_get_sset_count(struct mlx5e_priv *priv, int sset)
 		return MLX5E_NUM_PFLAGS;
 	case ETH_SS_TEST:
 		return mlx5e_self_test_num(priv);
-		fallthrough;
 		return -EOPNOTSUPP;

             reply	other threads:[~2020-08-03 14:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 14:34 Dan Carpenter [this message]
2020-08-03 15:48 ` Gustavo A. R. Silva
2020-08-19 19:29   ` Saeed Mahameed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803143448.GA346925@mwanda \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH net-next] net/mlx5: remove erroneous fallthrough' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).