Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sbrivio@redhat.com
Cc: fw@strlen.de, dsahern@gmail.com, aconole@redhat.com,
	nusiddiq@redhat.com, kuba@kernel.org, pshelar@ovn.org,
	roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
	lu@pplo.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/6] Support PMTU discovery with bridged UDP tunnels
Date: Tue, 04 Aug 2020 13:02:19 -0700 (PDT)	[thread overview]
Message-ID: <20200804.130219.1503615086211769091.davem@davemloft.net> (raw)
In-Reply-To: <cover.1596520062.git.sbrivio@redhat.com>

From: Stefano Brivio <sbrivio@redhat.com>
Date: Tue,  4 Aug 2020 07:53:41 +0200

> Currently, PMTU discovery for UDP tunnels only works if packets are
> routed to the encapsulating interfaces, not bridged.
> 
> This results from the fact that we generally don't have valid routes
> to the senders we can use to relay ICMP and ICMPv6 errors, and makes
> PMTU discovery completely non-functional for VXLAN and GENEVE ports of
> both regular bridges and Open vSwitch instances.
> 
> If the sender is local, and packets are forwarded to the port by a
> regular bridge, all it takes is to generate a corresponding route
> exception on the encapsulating device. The bridge then finds the route
> exception carrying the PMTU value estimate as it forwards frames, and
> relays ICMP messages back to the socket of the local sender. Patch 1/6
> fixes this case.
> 
> If the sender resides on another node, we actually need to reply to
> IP and IPv6 packets ourselves and send these ICMP or ICMPv6 errors
> back, using the same encapsulating device. Patch 2/6, based on an
> original idea by Florian Westphal, adds the needed functionality,
> while patches 3/6 and 4/6 add matching support for VXLAN and GENEVE.
> 
> Finally, 5/6 and 6/6 introduce selftests for all combinations of
> inner and outer IP versions, covering both VXLAN and GENEVE, with
> both regular bridges and Open vSwitch instances.
> 
> v2: Add helper to check for any bridge port, skip oif check for PMTU
>     routes for bridge ports only, split IPv4 and IPv6 helpers and
>     functions (all suggested by David Ahern)

Series applied with the extraneous newline in the selftest changes of
patch #5 removed.

Thank you.

      parent reply	other threads:[~2020-08-04 20:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04  5:53 Stefano Brivio
2020-08-04  5:53 ` [PATCH net-next v2 1/6] ipv4: route: Ignore output interface in FIB lookup for PMTU route Stefano Brivio
2020-08-04 13:54   ` David Ahern
2020-08-04  5:53 ` [PATCH net-next v2 2/6] tunnels: PMTU discovery support for directly bridged IP packets Stefano Brivio
2020-08-04 13:54   ` David Ahern
2020-08-05 16:54   ` Naresh Kamboju
2020-08-05 17:02     ` Stefano Brivio
2020-08-04  5:53 ` [PATCH net-next v2 3/6] vxlan: Support for PMTU discovery on directly bridged links Stefano Brivio
2020-08-04  5:53 ` [PATCH net-next v2 4/6] geneve: " Stefano Brivio
2020-08-04  5:53 ` [PATCH net-next v2 5/6] selftests: pmtu.sh: Add tests for bridged UDP tunnels Stefano Brivio
2020-08-04 14:00   ` David Ahern
2020-08-04 14:35     ` Stefano Brivio
2020-08-04  5:53 ` [PATCH net-next v2 6/6] selftests: pmtu.sh: Add tests for UDP tunnels handled by Open vSwitch Stefano Brivio
2020-08-04 20:02 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200804.130219.1503615086211769091.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=aconole@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=fw@strlen.de \
    --cc=kuba@kernel.org \
    --cc=lu@pplo.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=nusiddiq@redhat.com \
    --cc=pshelar@ovn.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=sbrivio@redhat.com \
    --subject='Re: [PATCH net-next v2 0/6] Support PMTU discovery with bridged UDP tunnels' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).