Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: cforno12@linux.ibm.com
Cc: netdev@vger.kernel.org, drt@linux.vnet.ibm.com
Subject: Re: [PATCH, net-next, v2] ibmvnic: store RX and TX subCRQ handle array in ibmvnic_adapter struct
Date: Tue, 18 Aug 2020 15:44:01 -0700 (PDT)	[thread overview]
Message-ID: <20200818.154401.826640119439302130.davem@davemloft.net> (raw)
In-Reply-To: <20200818215333.53183-1-cforno12@linux.ibm.com>

From: Cristobal Forno <cforno12@linux.ibm.com>
Date: Tue, 18 Aug 2020 16:53:33 -0500

> @@ -1524,7 +1519,7 @@ static netdev_tx_t ibmvnic_xmit(struct sk_buff *skb, struct net_device *netdev)
>  	unsigned int offset;
>  	int num_entries = 1;
>  	unsigned char *dst;
> -	u64 *handle_array;
> +	u64 handle;
>  	int index = 0;
>  	u8 proto = 0;
>  	netdev_tx_t ret = NETDEV_TX_OK;

Please preserve the reverse christmas tree ordering of local variables here.

Otherwise the patch looks fine to me.

  reply	other threads:[~2020-08-18 22:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 21:53 Cristobal Forno
2020-08-18 22:44 ` David Miller [this message]
2020-08-19 18:17   ` Cris Forno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200818.154401.826640119439302130.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=cforno12@linux.ibm.com \
    --cc=drt@linux.vnet.ibm.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH, net-next, v2] ibmvnic: store RX and TX subCRQ handle array in ibmvnic_adapter struct' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).