Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Coly Li <colyli@suse.de>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
stable <stable@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Hannes Reinecke <hare@suse.de>, Jan Kara <jack@suse.com>,
Jens Axboe <axboe@kernel.dk>,
Mikhail Skorzhinskii <mskorzhinskiy@solarflare.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
Sagi Grimberg <sagi@grimberg.me>,
Vlastimil Babka <vbabka@suse.com>
Subject: Re: [PATCH v5 1/3] net: introduce helper sendpage_ok() in include/linux/net.h
Date: Tue, 18 Aug 2020 09:00:10 +0200 [thread overview]
Message-ID: <20200818070010.GA2365@lst.de> (raw)
In-Reply-To: <CAM_iQpWnzm=cQZvZMcjKXez1L55tSVfWyadP3d0CUaT=D4nOhw@mail.gmail.com>
On Mon, Aug 17, 2020 at 12:12:12PM -0700, Cong Wang wrote:
>
> So netdev people will have to understand and support PageSlab() or
> page_count()?
Yes. As they came up with that contrived rule what is acceptable
for sendpage. No one else really knows and other subsystems like the
block layer are perfectly fine with it.
>
> If it is unusual even for mm people, how could netdev people suppose
> to understand this unusual mm bug? At least not any better.
It is not a mm bug, it is a networking quirk.
next prev parent reply other threads:[~2020-08-18 7:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-16 7:15 Coly Li
2020-08-16 7:15 ` [PATCH v5 2/3] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage() Coly Li
2020-08-16 7:15 ` [PATCH v5 3/3] drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage() Coly Li
2020-08-16 17:55 ` [PATCH v5 1/3] net: introduce helper sendpage_ok() in include/linux/net.h Cong Wang
2020-08-17 5:45 ` Christoph Hellwig
2020-08-17 19:12 ` Cong Wang
2020-08-18 7:00 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-16 7:08 Coly Li
2020-08-18 8:08 ` Eric Dumazet
2020-08-18 8:21 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818070010.GA2365@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=colyli@suse.de \
--cc=hare@suse.de \
--cc=jack@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mskorzhinskiy@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.com \
--cc=xiyou.wangcong@gmail.com \
--subject='Re: [PATCH v5 1/3] net: introduce helper sendpage_ok() in include/linux/net.h' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).