Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Andre Edich <andre.edich@microchip.com>
Cc: <netdev@vger.kernel.org>, <UNGLinuxDriver@microchip.com>,
	<steve.glendinning@shawell.net>,
	<Parthiban.Veerasooran@microchip.com>
Subject: Re: [PATCH net-next v3 3/3] smsc95xx: add phylib support
Date: Tue, 18 Aug 2020 08:25:10 -0700	[thread overview]
Message-ID: <20200818082510.380cd722@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200818111127.176422-4-andre.edich@microchip.com>

On Tue, 18 Aug 2020 13:11:27 +0200 Andre Edich wrote:
> +static inline int lan87xx_config_aneg(struct phy_device *phydev)

> +static inline int lan87xx_config_aneg_ext(struct phy_device *phydev)

Please don't use static inline in C files, the compiler will know what
to inline so it's unnecessary, and it hides dead code.

  reply	other threads:[~2020-08-18 15:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 11:11 [PATCH net-next v3 0/3] Add phylib support to smsc95xx Andre Edich
2020-08-18 11:11 ` [PATCH net-next v3 1/3] smsc95xx: remove redundant function arguments Andre Edich
2020-08-18 11:11 ` [PATCH net-next v3 2/3] smsc95xx: use usbnet->driver_priv Andre Edich
2020-08-18 11:11 ` [PATCH net-next v3 3/3] smsc95xx: add phylib support Andre Edich
2020-08-18 15:25   ` Jakub Kicinski [this message]
2020-08-19  1:51   ` Andrew Lunn
2020-08-19  1:58   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200818082510.380cd722@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=Parthiban.Veerasooran@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andre.edich@microchip.com \
    --cc=netdev@vger.kernel.org \
    --cc=steve.glendinning@shawell.net \
    --subject='Re: [PATCH net-next v3 3/3] smsc95xx: add phylib support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).