Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: "Ooi, Joyce" <joyce.ooi@intel.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dalon Westergreen <dalon.westergreen@linux.intel.com>,
	Tan Ley Foon <ley.foon.tan@intel.com>,
	See Chin Liang <chin.liang.see@intel.com>,
	Dinh Nguyen <dinh.nguyen@intel.com>,
	Dalon Westergreen <dalon.westergreen@intel.com>
Subject: Re: [PATCH v6 09/10] net: eth: altera: add msgdma prefetcher
Date: Tue, 18 Aug 2020 11:58:57 -0700	[thread overview]
Message-ID: <20200818115857.78d6b2ac@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200818154613.148921-10-joyce.ooi@intel.com>

On Tue, 18 Aug 2020 23:46:12 +0800 Ooi, Joyce wrote:
> From: Dalon Westergreen <dalon.westergreen@intel.com>
> 
> Add support for the mSGDMA prefetcher.  The prefetcher adds support
> for a linked list of descriptors in system memory.  The prefetcher
> feeds these to the mSGDMA dispatcher.

This generates warnings on 32bit builds:

../drivers/net/ethernet/altera/altera_msgdma_prefetcher.c: In function ‘msgdma_pref_initialize’:
../drivers/net/ethernet/altera/altera_msgdma_prefetcher.c:97:51: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘dma_addr_t’ {aka ‘unsigned int’} [-Wformat=]
   97 |   netdev_info(priv->dev, "%s: RX Desc mem at 0x%llx\n", __func__,
      |                                                ~~~^
      |                                                   |
      |                                                   long long unsigned int
      |                                                %x
   98 |        priv->pref_rxdescphys);
      |        ~~~~~~~~~~~~~~~~~~~~~                       
      |            |
      |            dma_addr_t {aka unsigned int}
../drivers/net/ethernet/altera/altera_msgdma_prefetcher.c:101:51: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘dma_addr_t’ {aka ‘unsigned int’} [-Wformat=]
  101 |   netdev_info(priv->dev, "%s: TX Desc mem at 0x%llx\n", __func__,
      |                                                ~~~^
      |                                                   |
      |                                                   long long unsigned int
      |                                                %x
  102 |        priv->pref_txdescphys);
      |        ~~~~~~~~~~~~~~~~~~~~~                       
      |            |
      |            dma_addr_t {aka unsigned int}

  reply	other threads:[~2020-08-18 18:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 15:46 [PATCH v6 00/10] net: eth: altera: tse: Add PTP and mSGDMA prefetcher Ooi, Joyce
2020-08-18 15:46 ` [PATCH v6 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response Ooi, Joyce
2020-08-18 15:46 ` [PATCH v6 02/10] net: eth: altera: set rx and tx ring size before init_dma call Ooi, Joyce
2020-08-18 15:46 ` [PATCH v6 03/10] net: eth: altera: fix altera_dmaops declaration Ooi, Joyce
2020-08-18 15:46 ` [PATCH v6 04/10] net: eth: altera: add optional function to start tx dma Ooi, Joyce
2020-08-18 15:46 ` [PATCH v6 05/10] net: eth: altera: Move common functions to altera_utils Ooi, Joyce
2020-08-18 15:46 ` [PATCH v6 06/10] net: eth: altera: Add missing identifier names to function declarations Ooi, Joyce
2020-08-18 15:46 ` [PATCH v6 07/10] net: eth: altera: change tx functions to type netdev_tx_t Ooi, Joyce
2020-08-18 15:46 ` [PATCH v6 08/10] net: eth: altera: add support for ptp and timestamping Ooi, Joyce
2020-08-18 18:58   ` Jakub Kicinski
2020-08-18 15:46 ` [PATCH v6 09/10] net: eth: altera: add msgdma prefetcher Ooi, Joyce
2020-08-18 18:58   ` Jakub Kicinski [this message]
2020-08-18 15:46 ` [PATCH v6 10/10] net: eth: altera: update devicetree bindings documentation Ooi, Joyce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200818115857.78d6b2ac@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=chin.liang.see@intel.com \
    --cc=dalon.westergreen@intel.com \
    --cc=dalon.westergreen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=dinh.nguyen@intel.com \
    --cc=joyce.ooi@intel.com \
    --cc=ley.foon.tan@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH v6 09/10] net: eth: altera: add msgdma prefetcher' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).