Netdev Archive on lore.kernel.org help / color / mirror / Atom feed
From: David Awogbemila <awogbemila@google.com> To: netdev@vger.kernel.org Cc: David Awogbemila <awogbemila@google.com> Subject: [PATCH net-next 16/18] gve: Also WARN for skb index equals num_queues. Date: Tue, 18 Aug 2020 12:44:15 -0700 [thread overview] Message-ID: <20200818194417.2003932-17-awogbemila@google.com> (raw) In-Reply-To: <20200818194417.2003932-1-awogbemila@google.com> The WARN condition currently checks if the skb's queue_mapping is (strictly) greater than tx_cfg.num_queues. queue_mapping == tx_cfg.num_queues should also be invalid and trigger the WARNing. Use WARN_ON_ONCE instead otherwise the host will be stuck in syslog flood. Signed-off-by: David Awogbemila <awogbemila@google.com> --- drivers/net/ethernet/google/gve/gve_tx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/google/gve/gve_tx.c b/drivers/net/ethernet/google/gve/gve_tx.c index 5d75dec1c520..5beff4d4d2e3 100644 --- a/drivers/net/ethernet/google/gve/gve_tx.c +++ b/drivers/net/ethernet/google/gve/gve_tx.c @@ -602,8 +602,7 @@ netdev_tx_t gve_tx(struct sk_buff *skb, struct net_device *dev) struct gve_tx_ring *tx; int nsegs; - WARN(skb_get_queue_mapping(skb) > priv->tx_cfg.num_queues, - "skb queue index out of range"); + WARN_ON_ONCE(skb_get_queue_mapping(skb) >= priv->tx_cfg.num_queues); tx = &priv->tx[skb_get_queue_mapping(skb)]; if (unlikely(gve_maybe_stop_tx(tx, skb))) { /* We need to ring the txq doorbell -- we have stopped the Tx -- 2.28.0.220.ged08abb693-goog
next prev parent reply other threads:[~2020-08-18 19:45 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-18 19:43 [PATCH net-next 00/18] GVE Driver v1.1.0 Features David Awogbemila 2020-08-18 19:44 ` [PATCH net-next 01/18] gve: Get and set Rx copybreak via ethtool David Awogbemila 2020-08-18 20:00 ` Andrew Lunn 2020-08-18 19:44 ` [PATCH net-next 02/18] gve: Add stats for gve David Awogbemila 2020-08-18 19:44 ` [PATCH net-next 03/18] gve: Register netdev earlier David Awogbemila 2020-08-18 20:09 ` Andrew Lunn 2020-08-18 19:44 ` [PATCH net-next 04/18] gve: Add support for dma_mask register David Awogbemila 2020-08-18 20:15 ` Andrew Lunn 2020-08-18 19:44 ` [PATCH net-next 05/18] gve: Add Gvnic stats AQ command and ethtool show/set-priv-flags David Awogbemila 2020-08-19 3:13 ` Jakub Kicinski 2020-08-25 15:46 ` David Awogbemila 2020-08-25 16:46 ` Jakub Kicinski 2020-08-26 0:06 ` David Awogbemila 2020-08-26 0:53 ` Jakub Kicinski 2020-08-27 19:24 ` David Awogbemila 2020-08-18 19:44 ` [PATCH net-next 06/18] gve: Batch AQ commands for creating and destroying queues David Awogbemila 2020-08-18 20:16 ` David Miller 2020-08-18 22:25 ` David Awogbemila 2020-08-18 19:44 ` [PATCH net-next 07/18] gve: Use link status register to report link status David Awogbemila 2020-08-19 3:36 ` Jakub Kicinski 2020-08-25 15:46 ` David Awogbemila 2020-08-18 19:44 ` [PATCH net-next 08/18] gve: Enable Link Speed Reporting in the driver David Awogbemila 2020-08-18 21:30 ` Jakub Kicinski 2020-08-18 19:44 ` [PATCH net-next 09/18] gve: Add support for raw addressing device option David Awogbemila 2020-08-18 19:44 ` [PATCH net-next 10/18] gve: Add support for raw addressing to the rx path David Awogbemila 2020-08-18 20:18 ` David Miller 2020-08-18 22:25 ` David Awogbemila 2020-08-18 19:44 ` [PATCH net-next 11/18] gve: Add support for raw addressing in the tx path David Awogbemila 2020-08-18 19:44 ` [PATCH net-next 12/18] gve: Add netif_set_xps_queue call David Awogbemila 2020-08-18 19:44 ` [PATCH net-next 13/18] gve: Add rx buffer pagecnt bias David Awogbemila 2020-08-18 19:44 ` [PATCH net-next 14/18] gve: Move the irq db indexes out of the ntfy block struct David Awogbemila 2020-08-18 19:44 ` [PATCH net-next 15/18] gve: Prefetch packet pages and packet descriptors David Awogbemila 2020-08-18 19:44 ` David Awogbemila [this message] 2020-08-18 19:44 ` [PATCH net-next 17/18] gve: Switch to use napi_complete_done David Awogbemila 2020-08-18 19:44 ` [PATCH net-next 18/18] gve: Bump version to 1.1.0 David Awogbemila 2020-08-19 3:40 ` Jakub Kicinski 2020-08-18 20:19 ` [PATCH net-next 00/18] GVE Driver v1.1.0 Features David Miller 2020-08-18 22:24 ` David Awogbemila
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200818194417.2003932-17-awogbemila@google.com \ --to=awogbemila@google.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).