Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: xiangxia.m.yue@gmail.com
Cc: dev@openvswitch.org, netdev@vger.kernel.org, pshelar@ovn.org
Subject: Re: [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function
Date: Wed, 19 Aug 2020 18:52:09 -0700 (PDT) [thread overview]
Message-ID: <20200819.185209.697239873202931307.davem@davemloft.net> (raw)
In-Reply-To: <CAMDZJNVcuN29b5S0JxqzEcw4yG6S+TVSpwkiohYJMgE0TU45PA@mail.gmail.com>
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Date: Thu, 20 Aug 2020 07:21:33 +0800
> On Thu, Aug 20, 2020 at 6:52 AM David Miller <davem@davemloft.net> wrote:
>
>> From: xiangxia.m.yue@gmail.com
>>
>> Date: Tue, 18 Aug 2020 18:09:22 +0800
>>
>>
>>
>> > Decrease table->count and ufid_count unconditionally,
>>
>>
>>
>> You don't explain why this is a valid transformation.
>>
>>
>>
>> Is it a bug fix?
>
> No
>
>>
>>
>>
>> Can it never happen?
>>
>>
>>
>> What are the details and how did you determine this?
>
> I want to simplify the codes, when flushing the flow, previous codes don't
> count the flow, because we have set them(flow counter/ufid counter)to 0.
> Now don't set counter and count flow and ufid flow when deleting them, and
> I add BUG_ON to make sure other patch no bug when flushing flow.
Add these details to your commit message, please.
next prev parent reply other threads:[~2020-08-20 1:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 10:09 [PATCH net-next v1 0/3] net: openvswitch: improve codes xiangxia.m.yue
2020-08-18 10:09 ` [PATCH net-next v1 1/3] net: openvswitch: improve coding style xiangxia.m.yue
2020-08-18 10:09 ` [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function xiangxia.m.yue
2020-08-19 22:52 ` David Miller
[not found] ` <CAMDZJNVcuN29b5S0JxqzEcw4yG6S+TVSpwkiohYJMgE0TU45PA@mail.gmail.com>
2020-08-20 1:52 ` David Miller [this message]
2020-08-24 7:39 ` Tonghao Zhang
2020-08-18 10:09 ` [PATCH net-next v1 3/3] net: openvswitch: remove unnused keep_flows xiangxia.m.yue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819.185209.697239873202931307.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=xiangxia.m.yue@gmail.com \
--subject='Re: [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).