From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE51C433E1 for ; Thu, 20 Aug 2020 01:52:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F0EB207DA for ; Thu, 20 Aug 2020 01:52:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726646AbgHTBwS (ORCPT ); Wed, 19 Aug 2020 21:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726435AbgHTBwR (ORCPT ); Wed, 19 Aug 2020 21:52:17 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC8A5C061757 for ; Wed, 19 Aug 2020 18:52:17 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1192711FFF624; Wed, 19 Aug 2020 18:35:28 -0700 (PDT) Date: Wed, 19 Aug 2020 18:52:09 -0700 (PDT) Message-Id: <20200819.185209.697239873202931307.davem@davemloft.net> To: xiangxia.m.yue@gmail.com Cc: dev@openvswitch.org, netdev@vger.kernel.org, pshelar@ovn.org Subject: Re: [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function From: David Miller In-Reply-To: References: <20200818100923.46840-3-xiangxia.m.yue@gmail.com> <20200819.155207.713791050216186108.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 19 Aug 2020 18:35:28 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tonghao Zhang Date: Thu, 20 Aug 2020 07:21:33 +0800 > On Thu, Aug 20, 2020 at 6:52 AM David Miller wrote: > >> From: xiangxia.m.yue@gmail.com >> >> Date: Tue, 18 Aug 2020 18:09:22 +0800 >> >> >> >> > Decrease table->count and ufid_count unconditionally, >> >> >> >> You don't explain why this is a valid transformation. >> >> >> >> Is it a bug fix? > > No > >> >> >> >> Can it never happen? >> >> >> >> What are the details and how did you determine this? > > I want to simplify the codes, when flushing the flow, previous codes don't > count the flow, because we have set them(flow counter/ufid counter)to 0. > Now don't set counter and count flow and ufid flow when deleting them, and > I add BUG_ON to make sure other patch no bug when flushing flow. Add these details to your commit message, please.