From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F325DC433E3 for ; Wed, 19 Aug 2020 01:58:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA7A0204EC for ; Wed, 19 Aug 2020 01:58:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726885AbgHSB6c (ORCPT ); Tue, 18 Aug 2020 21:58:32 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60450 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbgHSB6b (ORCPT ); Tue, 18 Aug 2020 21:58:31 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k8DMy-00A1Dq-O5; Wed, 19 Aug 2020 03:58:28 +0200 Date: Wed, 19 Aug 2020 03:58:28 +0200 From: Andrew Lunn To: Andre Edich Cc: netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, steve.glendinning@shawell.net, Parthiban.Veerasooran@microchip.com Subject: Re: [PATCH net-next v3 3/3] smsc95xx: add phylib support Message-ID: <20200819015828.GB2347062@lunn.ch> References: <20200818111127.176422-1-andre.edich@microchip.com> <20200818111127.176422-4-andre.edich@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200818111127.176422-4-andre.edich@microchip.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > @@ -553,32 +554,21 @@ static int smsc95xx_phy_update_flowcontrol(struct usbnet *dev, u8 duplex, > static int smsc95xx_link_reset(struct usbnet *dev) > { > struct smsc95xx_priv *pdata = dev->driver_priv; > - struct mii_if_info *mii = &dev->mii; > - struct ethtool_cmd ecmd = { .cmd = ETHTOOL_GSET }; > + struct ethtool_link_ksettings cmd; > unsigned long flags; > u16 lcladv, rmtadv; > int ret; > > - /* clear interrupt status */ > - ret = smsc95xx_mdio_read(dev->net, mii->phy_id, PHY_INT_SRC); > - if (ret < 0) > - return ret; > - > ret = smsc95xx_write_reg(dev, INT_STS, INT_STS_CLEAR_ALL_); > if (ret < 0) > return ret; > > - mii_check_media(mii, 1, 1); > - mii_ethtool_gset(&dev->mii, &ecmd); > - lcladv = smsc95xx_mdio_read(dev->net, mii->phy_id, MII_ADVERTISE); > - rmtadv = smsc95xx_mdio_read(dev->net, mii->phy_id, MII_LPA); > - > - netif_dbg(dev, link, dev->net, > - "speed: %u duplex: %d lcladv: %04x rmtadv: %04x\n", > - ethtool_cmd_speed(&ecmd), ecmd.duplex, lcladv, rmtadv); > + phy_ethtool_ksettings_get(pdata->phydev, &cmd); > + lcladv = phy_read(pdata->phydev, MII_ADVERTISE); > + rmtadv = phy_read(pdata->phydev, MII_LPA); The MAC driver should not be making phy_read() calls. Please look at how other driver handle flow control. Andrew