Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: sameehj@amazon.com
Cc: davem@davemloft.net, netdev@vger.kernel.org, dwmw@amazon.com,
	zorik@amazon.com, matua@amazon.com, saeedb@amazon.com,
	msw@amazon.com, aliguori@amazon.com, nafea@amazon.com,
	gtzalik@amazon.com, netanel@amazon.com, alisaidi@amazon.com,
	benh@amazon.com, akiyano@amazon.com, ndagan@amazon.com
Subject: Re: [PATCH V2 net-next 2/4] net: ena: ethtool: Add new device statistics
Date: Wed, 19 Aug 2020 16:18:56 +0200	[thread overview]
Message-ID: <20200819141856.GF2403519@lunn.ch> (raw)
In-Reply-To: <20200819134349.22129-3-sameehj@amazon.com>

> +	if (eni_stats_needed) {
> +		ena_update_hw_stats(adapter);
> +		for (i = 0; i < ENA_STATS_ARRAY_ENI(adapter); i++) {
> +			ena_stats = &ena_stats_eni_strings[i];
> +
> +			ptr = (u64 *)((unsigned long)&adapter->eni_stats +
> +				ena_stats->stat_offset);

Yet more ugly casts. Please fix this. If done correctly, you should
not need any casts at all.

    Andrew

  reply	other threads:[~2020-08-19 14:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19 13:43 [PATCH V2 net-next 0/4] Enhance current features in ena driver sameehj
2020-08-19 13:43 ` [PATCH V2 net-next 1/4] net: ena: ethtool: use unsigned long for pointer arithmetics sameehj
2020-08-19 14:17   ` Andrew Lunn
2020-08-20 12:13     ` Jubran, Samih
2020-08-26 15:36       ` Maciej Fijalkowski
2020-09-06 10:47         ` Shay Agroskin
2020-09-06 16:45           ` Jakub Kicinski
2020-08-26 10:48     ` Jubran, Samih
2020-08-19 13:43 ` [PATCH V2 net-next 2/4] net: ena: ethtool: Add new device statistics sameehj
2020-08-19 14:18   ` Andrew Lunn [this message]
2020-08-19 13:43 ` [PATCH V2 net-next 3/4] net: ena: ethtool: add stats printing to XDP queues sameehj
2020-08-19 13:43 ` [PATCH V2 net-next 4/4] net: ena: xdp: add queue counters for xdp actions sameehj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200819141856.GF2403519@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=akiyano@amazon.com \
    --cc=aliguori@amazon.com \
    --cc=alisaidi@amazon.com \
    --cc=benh@amazon.com \
    --cc=davem@davemloft.net \
    --cc=dwmw@amazon.com \
    --cc=gtzalik@amazon.com \
    --cc=matua@amazon.com \
    --cc=msw@amazon.com \
    --cc=nafea@amazon.com \
    --cc=ndagan@amazon.com \
    --cc=netanel@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedb@amazon.com \
    --cc=sameehj@amazon.com \
    --cc=zorik@amazon.com \
    --subject='Re: [PATCH V2 net-next 2/4] net: ena: ethtool: Add new device statistics' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).