From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE3B3C433DF for ; Wed, 19 Aug 2020 14:19:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3EE920639 for ; Wed, 19 Aug 2020 14:19:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728462AbgHSOTB (ORCPT ); Wed, 19 Aug 2020 10:19:01 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:33574 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726560AbgHSOS5 (ORCPT ); Wed, 19 Aug 2020 10:18:57 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k8OvY-00A5sj-LI; Wed, 19 Aug 2020 16:18:56 +0200 Date: Wed, 19 Aug 2020 16:18:56 +0200 From: Andrew Lunn To: sameehj@amazon.com Cc: davem@davemloft.net, netdev@vger.kernel.org, dwmw@amazon.com, zorik@amazon.com, matua@amazon.com, saeedb@amazon.com, msw@amazon.com, aliguori@amazon.com, nafea@amazon.com, gtzalik@amazon.com, netanel@amazon.com, alisaidi@amazon.com, benh@amazon.com, akiyano@amazon.com, ndagan@amazon.com Subject: Re: [PATCH V2 net-next 2/4] net: ena: ethtool: Add new device statistics Message-ID: <20200819141856.GF2403519@lunn.ch> References: <20200819134349.22129-1-sameehj@amazon.com> <20200819134349.22129-3-sameehj@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200819134349.22129-3-sameehj@amazon.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > + if (eni_stats_needed) { > + ena_update_hw_stats(adapter); > + for (i = 0; i < ENA_STATS_ARRAY_ENI(adapter); i++) { > + ena_stats = &ena_stats_eni_strings[i]; > + > + ptr = (u64 *)((unsigned long)&adapter->eni_stats + > + ena_stats->stat_offset); Yet more ugly casts. Please fix this. If done correctly, you should not need any casts at all. Andrew