Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Nick Clifton <nickc@redhat.com>
Cc: Mark Wielaard <mark@klomp.org>,
	Jesper Dangaard Brouer <brouer@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	sdf@google.com, andriin@fb.com
Subject: Re: Kernel build error on BTFIDS vmlinux
Date: Wed, 19 Aug 2020 19:18:49 +0200	[thread overview]
Message-ID: <20200819171820.GG177896@krava> (raw)
In-Reply-To: <0ddf7bc5-be05-cc06-05d7-2778c53d023b@redhat.com>

On Wed, Aug 19, 2020 at 04:34:30PM +0100, Nick Clifton wrote:
> Hi Mark,
> 
> > Adding Nick, the binutils maintainer, so we can make sure
> > binutils/elfutils agree on some ELF section compression corner case.
> 
> Thanks for doing this.
> 
> > But it would obviously be better if that wasn't necessary. So I'll try
> > to fix libelf so that if it fixes up the alignment when reading the
> > compressed data, it also does that when writing out the data again. But
> > that would only help for a new version of elfutils.
> > 
> > So it would be nice if binutils ld could also be fixed to write out
> > compressed sections with the correct alignment.
> 
> OK, I will look into doing this.
> 
> By any chance is there a small test case that you are using to check
> this behaviour ?   If so, please may I have a copy for myself ?

so when I take empty object and compile like:

  $ echo 'int main(int argc, char **argv) { return 0; }' | gcc -c -o ex.o -g -gz=zlib -x c -
  $ ld -o ex --compress-debug-sections=zlib ex.o

then there's .debug_info section that shows sh_addralign = 1
after I open the 'ex' obejct with elf_begin and iterate sections

according to Mark that should be 8 (on 64 bits)

when I change it to 8, the elf_update call won't fail for me
on that elf file

thanks,
jirka


  reply	other threads:[~2020-08-19 17:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18  8:55 Jesper Dangaard Brouer
2020-08-18  9:14 ` Jiri Olsa
2020-08-18 10:56   ` Jiri Olsa
2020-08-18 13:45     ` Jiri Olsa
2020-08-18 16:33       ` Jesper Dangaard Brouer
2020-08-18 17:29         ` Mark Wielaard
2020-08-19 15:34           ` Nick Clifton
2020-08-19 17:18             ` Jiri Olsa [this message]
2020-08-19 22:00               ` Mark Wielaard
2020-08-20 12:14                 ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200819171820.GG177896@krava \
    --to=jolsa@redhat.com \
    --cc=andriin@fb.com \
    --cc=brouer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@klomp.org \
    --cc=netdev@vger.kernel.org \
    --cc=nickc@redhat.com \
    --cc=sdf@google.com \
    --subject='Re: Kernel build error on BTFIDS vmlinux' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).