Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: davthompson@nvidia.com
Cc: kuba@kernel.org, dthompson@mellanox.com, netdev@vger.kernel.org,
	jiri@mellanox.com, Asmaa@mellanox.com
Subject: Re: [PATCH net-next v2] Add Mellanox BlueField Gigabit Ethernet driver
Date: Thu, 20 Aug 2020 15:48:25 -0700 (PDT)	[thread overview]
Message-ID: <20200820.154825.1980624947360309997.davem@davemloft.net> (raw)
In-Reply-To: <MN2PR12MB2975DAA7292C27DEB0B518A8C75A0@MN2PR12MB2975.namprd12.prod.outlook.com>

From: David Thompson <davthompson@nvidia.com>
Date: Thu, 20 Aug 2020 18:51:39 +0000

> When I wrote the Kconfig definition I was thinking that "INET" is an
> obvious functional dependency for an Ethernet driver.

People can and should be able to use your driver even if ipv4/ipv6 is
disabled, don't you think?

> Yes, the mlxbf_gige silicon block needs to be programmed with the
> buffer's physical address so that the silicon logic can DMA incoming
> packet data into the buffer.  The kernel API "dma_alloc_coherent()"
> meets the driver's requirements in that it returns a CPU-useable address
> as well as a bus/physical address (used by silicon).

For descriptors and statistics blocks, coherent DMA memory makes sense.

For packet data, it does not.  These are streaming blocks of memory that
have their cohernecy managed by appropriate map/unmap/sync calls.

  parent reply	other threads:[~2020-08-20 22:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30 22:53 David Thompson
2020-07-31  0:30 ` Jakub Kicinski
2020-08-20 18:51   ` David Thompson
2020-08-20 19:25     ` Jakub Kicinski
2020-08-20 22:48     ` David Miller [this message]
2020-08-20 23:04   ` Vladimir Oltean
2020-08-21  0:14     ` Jakub Kicinski
2020-08-21 10:35       ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820.154825.1980624947360309997.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Asmaa@mellanox.com \
    --cc=davthompson@nvidia.com \
    --cc=dthompson@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-next v2] Add Mellanox BlueField Gigabit Ethernet driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).