Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	bpf@vger.kernel.org, netdev@vger.kernel.org,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	kernel-team@fb.com
Subject: Re: [PATCH bpf-next 1/3] bpf: implement link_query for bpf iterators
Date: Thu, 20 Aug 2020 15:31:11 -0700	[thread overview]
Message-ID: <20200820223111.6dbbp53rpszht4uf@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <3270dbc2-7f7d-b05c-7244-9fee18503a1f@fb.com>

On Thu, Aug 20, 2020 at 09:15:30AM -0700, Yonghong Song wrote:
> 
> 
> On 8/20/20 8:07 AM, Jakub Kicinski wrote:
> > On Wed, 19 Aug 2020 17:13:23 -0700 Yonghong Song wrote:
> > > +	fill_link_info = iter_link->tinfo->reg_info->fill_link_info;
> > > +	if (fill_link_info)
> > > +		return fill_link_info(&iter_link->aux, info);
> > > +
> > > +        return 0;
> > 
> > ERROR: code indent should use tabs where possible
> > #138: FILE: kernel/bpf/bpf_iter.c:433:
> > +        return 0;$
> > 
> > WARNING: please, no spaces at the start of a line
> > #138: FILE: kernel/bpf/bpf_iter.c:433:
> > +        return 0;$
> 
> 
> Thanks for reporting! Will wait a little bit for further
> comments and send v2.

all looks good to me.

  reply	other threads:[~2020-08-20 22:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20  0:13 [PATCH bpf-next 0/3] " Yonghong Song
2020-08-20  0:13 ` [PATCH bpf-next 1/3] " Yonghong Song
2020-08-20 15:07   ` Jakub Kicinski
2020-08-20 16:15     ` Yonghong Song
2020-08-20 22:31       ` Alexei Starovoitov [this message]
2020-08-20  0:13 ` [PATCH bpf-next 2/3] bpf: implement link_query callbacks in map element iterators Yonghong Song
2020-08-20  0:13 ` [PATCH bpf-next 3/3] bpftool: implement link_query for bpf iterators Yonghong Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820223111.6dbbp53rpszht4uf@ast-mbp.dhcp.thefacebook.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yhs@fb.com \
    --subject='Re: [PATCH bpf-next 1/3] bpf: implement link_query for bpf iterators' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).