Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Thompson <dthompson@mellanox.com>,
	netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com,
	Asmaa Mnebhi <asmaa@mellanox.com>
Subject: Re: [PATCH net-next v2] Add Mellanox BlueField Gigabit Ethernet driver
Date: Fri, 21 Aug 2020 02:04:39 +0300	[thread overview]
Message-ID: <20200820230439.5duakpmsg7jysdwq@skbuf> (raw)
In-Reply-To: <20200730173059.7440e21c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On Thu, Jul 30, 2020 at 05:30:59PM -0700, Jakub Kicinski wrote:
> On Thu, 30 Jul 2020 18:53:58 -0400 David Thompson wrote:
> > +
> > +	/* Tell networking subsystem to poll GigE driver */
> > +	napi_schedule(&priv->napi);
> 
> _irqoff

Hmm, I wouldn't be so sure about this particular advice. With
PREEMPT_RT, interrupt handlers are force-threaded and run in process
context, therefore with hardirqs enabled. This driver doesn't call
request_irq with IRQF_NO_THREAD, so calling napi_schedule_irqoff would
create a bug that is very, very difficult to find.

Thanks,
-Vladimir

  parent reply	other threads:[~2020-08-20 23:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30 22:53 David Thompson
2020-07-31  0:30 ` Jakub Kicinski
2020-08-20 18:51   ` David Thompson
2020-08-20 19:25     ` Jakub Kicinski
2020-08-20 22:48     ` David Miller
2020-08-20 23:04   ` Vladimir Oltean [this message]
2020-08-21  0:14     ` Jakub Kicinski
2020-08-21 10:35       ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820230439.5duakpmsg7jysdwq@skbuf \
    --to=olteanv@gmail.com \
    --cc=asmaa@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=dthompson@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-next v2] Add Mellanox BlueField Gigabit Ethernet driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).