Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Igor Russkikh <irusskikh@marvell.com>
Cc: <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Ariel Elior <aelior@marvell.com>,
Michal Kalderon <mkalderon@marvell.com>,
"Alexander Lobakin" <alobakin@marvell.com>,
Michal Kalderon <michal.kalderon@marvell.com>
Subject: Re: [PATCH v6 net-next 04/10] qed: implement devlink info request
Date: Fri, 21 Aug 2020 10:32:18 -0700 [thread overview]
Message-ID: <20200821103218.6d1cb211@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <20200820185204.652-5-irusskikh@marvell.com>
On Thu, 20 Aug 2020 21:51:58 +0300 Igor Russkikh wrote:
> Here we return existing fw & mfw versions, we also fetch device's
> serial number:
>
> ~$ sudo ~/iproute2/devlink/devlink dev info
> pci/0000:01:00.1:
> driver qed
> board.serial_number REE1915E44552
> versions:
> running:
> fw.app 8.42.2.0
> stored:
> fw.mgmt 8.52.10.0
Are you not able to report the running version of the stored firmware?
The two sections are used for checking if machine needs fw-activation
or reboot (i.e. if fw.mgmt in stored section does not match fw.mgmt in
running - there is a new FW to activate).
> MFW and FW are different firmwares on device.
> Management is a firmware responsible for link configuration and
> various control plane features. Its permanent and resides in NVM.
>
> Running FW (or fastpath FW) is an embedded microprogram implementing
> all the packet processing, offloads, etc. This FW is being loaded
> on each start by the driver from FW binary blob.
>
> The base device specific structure (qed_dev_info) was not directly
> available to the base driver before. Thus, here we create and store
> a private copy of this structure in qed_dev root object to
> access the data.
In general looks good:
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2020-08-21 17:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 18:51 [PATCH v6 net-next 00/10] qed: introduce devlink health support Igor Russkikh
2020-08-20 18:51 ` [PATCH v6 net-next 01/10] qed: move out devlink logic into a new file Igor Russkikh
2020-08-21 17:56 ` Jesse Brandeburg
2020-08-20 18:51 ` [PATCH v6 net-next 02/10] qed/qede: make devlink survive recovery Igor Russkikh
2020-08-21 18:18 ` Jesse Brandeburg
2020-08-20 18:51 ` [PATCH v6 net-next 03/10] qed: fix kconfig help entries Igor Russkikh
2020-08-20 18:51 ` [PATCH v6 net-next 04/10] qed: implement devlink info request Igor Russkikh
2020-08-21 17:32 ` Jakub Kicinski [this message]
2020-08-23 10:57 ` [EXT] " Igor Russkikh
2020-08-20 18:51 ` [PATCH v6 net-next 05/10] qed: health reporter init deinit seq Igor Russkikh
2020-08-21 17:34 ` Jakub Kicinski
2020-08-20 18:52 ` [PATCH v6 net-next 06/10] qed: use devlink logic to report errors Igor Russkikh
2020-08-21 17:34 ` Jakub Kicinski
2020-08-20 18:52 ` [PATCH v6 net-next 07/10] qed*: make use of devlink recovery infrastructure Igor Russkikh
2020-08-21 17:35 ` Jakub Kicinski
2020-08-20 18:52 ` [PATCH v6 net-next 08/10] qed: implement devlink dump Igor Russkikh
2020-08-20 18:52 ` [PATCH v6 net-next 09/10] qed: align adjacent indent Igor Russkikh
2020-08-21 19:40 ` Jesse Brandeburg
2020-08-20 18:52 ` [PATCH v6 net-next 10/10] qede: make driver reliable on unload after failures Igor Russkikh
2020-08-21 19:54 ` [PATCH v6 net-next 00/10] qed: introduce devlink health support Jesse Brandeburg
2020-08-21 20:37 ` [EXT] " Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821103218.6d1cb211@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=aelior@marvell.com \
--cc=alobakin@marvell.com \
--cc=davem@davemloft.net \
--cc=irusskikh@marvell.com \
--cc=michal.kalderon@marvell.com \
--cc=mkalderon@marvell.com \
--cc=netdev@vger.kernel.org \
--subject='Re: [PATCH v6 net-next 04/10] qed: implement devlink info request' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).