From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39AE7C433E1 for ; Fri, 21 Aug 2020 19:40:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 146402072D for ; Fri, 21 Aug 2020 19:40:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726433AbgHUTkH (ORCPT ); Fri, 21 Aug 2020 15:40:07 -0400 Received: from mga09.intel.com ([134.134.136.24]:61612 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725831AbgHUTkG (ORCPT ); Fri, 21 Aug 2020 15:40:06 -0400 IronPort-SDR: +P6NMTUkneZj9KDVD1VyhiIClrhUIus+f/sdqpmv4+XKUChf8+P9nhpZ+smoHb7Z/y8jCa4xVy L3O6pZLZfaug== X-IronPort-AV: E=McAfee;i="6000,8403,9720"; a="156675575" X-IronPort-AV: E=Sophos;i="5.76,338,1592895600"; d="scan'208";a="156675575" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 12:40:06 -0700 IronPort-SDR: edfcIL4xn3b/WjdvPb1x7qTWAE3rl/iKXL8jlFbd+lbid6HuNDnstWZ15BNrIn8D/TIPT94DiR c+9IZn2km4mw== X-IronPort-AV: E=Sophos;i="5.76,338,1592895600"; d="scan'208";a="473156335" Received: from jbrandeb-mobl3.amr.corp.intel.com (HELO localhost) ([10.212.38.54]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 12:40:05 -0700 Date: Fri, 21 Aug 2020 12:40:04 -0700 From: Jesse Brandeburg To: Igor Russkikh Cc: , "David S . Miller" , Jakub Kicinski , Ariel Elior , Michal Kalderon , "Alexander Lobakin" , Michal Kalderon Subject: Re: [PATCH v6 net-next 09/10] qed: align adjacent indent Message-ID: <20200821124004.000026b5@intel.com> In-Reply-To: <20200820185204.652-10-irusskikh@marvell.com> References: <20200820185204.652-1-irusskikh@marvell.com> <20200820185204.652-10-irusskikh@marvell.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Igor Russkikh wrote: > Fix indent on some of adjacent declarations. > > Signed-off-by: Igor Russkikh > Signed-off-by: Alexander Lobakin > Signed-off-by: Michal Kalderon > --- > include/linux/qed/qed_if.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h > index 1297726f2b25..b8fb80c9be80 100644 > --- a/include/linux/qed/qed_if.h > +++ b/include/linux/qed/qed_if.h > @@ -897,14 +897,14 @@ struct qed_common_ops { > > void (*simd_handler_clean)(struct qed_dev *cdev, > int index); > - int (*dbg_grc)(struct qed_dev *cdev, > - void *buffer, u32 *num_dumped_bytes); > + int (*dbg_grc)(struct qed_dev *cdev, > + void *buffer, u32 *num_dumped_bytes); > > - int (*dbg_grc_size)(struct qed_dev *cdev); > + int (*dbg_grc_size)(struct qed_dev *cdev); > > - int (*dbg_all_data) (struct qed_dev *cdev, void *buffer); > + int (*dbg_all_data)(struct qed_dev *cdev, void *buffer); > > - int (*dbg_all_data_size) (struct qed_dev *cdev); > + int (*dbg_all_data_size)(struct qed_dev *cdev); > > int (*report_fatal_error)(struct devlink *devlink, > enum qed_hw_err_type err_type); Was there a reason to do the indenting? I would just replace this patch with unindenting everything. In general over time the time indent thing is unmaintainable and just generates inconsistency over time.