Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Igor Russkikh <irusskikh@marvell.com>
Cc: <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Ariel Elior <aelior@marvell.com>,
Michal Kalderon <mkalderon@marvell.com>
Subject: Re: [PATCH v6 net-next 00/10] qed: introduce devlink health support
Date: Fri, 21 Aug 2020 12:54:10 -0700 [thread overview]
Message-ID: <20200821125410.00005c08@intel.com> (raw)
In-Reply-To: <20200820185204.652-1-irusskikh@marvell.com>
Igor Russkikh wrote:
> This is a followup implementation after series
>
> https://patchwork.ozlabs.org/project/netdev/cover/20200514095727.1361-1-irusskikh@marvell.com/
>
> This is an implementation of devlink health infrastructure.
>
> With this we are now able to report HW errors to devlink, and it'll take
> its own actions depending on user configuration to capture and store the
> dump at the bad moment, and to request the driver to recover the device.
>
> So far we do not differentiate global device failures or specific PCI
> function failures. This means that some errors specific to one physical
> function will affect an entire device. This is not yet fully designed
> and verified, will followup in future.
>
> Solution was verified with artificial HW errors generated, existing
> tools for dump analysis could be used.
>
> v6: patch 4: changing serial to board.serial and fw to fw.app
> v5: improved patch 4 description
> v4:
> - commit message and other fixes after Jiri's comments
> - removed one patch (will send to net)
> v3: fix uninit var usage in patch 11
> v2: fix #include issue from kbuild test robot.
>
I think you're really close, please address the two patches I had
comments on and then I'd say you can add my Reviewed-by.
next prev parent reply other threads:[~2020-08-21 19:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 18:51 Igor Russkikh
2020-08-20 18:51 ` [PATCH v6 net-next 01/10] qed: move out devlink logic into a new file Igor Russkikh
2020-08-21 17:56 ` Jesse Brandeburg
2020-08-20 18:51 ` [PATCH v6 net-next 02/10] qed/qede: make devlink survive recovery Igor Russkikh
2020-08-21 18:18 ` Jesse Brandeburg
2020-08-20 18:51 ` [PATCH v6 net-next 03/10] qed: fix kconfig help entries Igor Russkikh
2020-08-20 18:51 ` [PATCH v6 net-next 04/10] qed: implement devlink info request Igor Russkikh
2020-08-21 17:32 ` Jakub Kicinski
2020-08-23 10:57 ` [EXT] " Igor Russkikh
2020-08-20 18:51 ` [PATCH v6 net-next 05/10] qed: health reporter init deinit seq Igor Russkikh
2020-08-21 17:34 ` Jakub Kicinski
2020-08-20 18:52 ` [PATCH v6 net-next 06/10] qed: use devlink logic to report errors Igor Russkikh
2020-08-21 17:34 ` Jakub Kicinski
2020-08-20 18:52 ` [PATCH v6 net-next 07/10] qed*: make use of devlink recovery infrastructure Igor Russkikh
2020-08-21 17:35 ` Jakub Kicinski
2020-08-20 18:52 ` [PATCH v6 net-next 08/10] qed: implement devlink dump Igor Russkikh
2020-08-20 18:52 ` [PATCH v6 net-next 09/10] qed: align adjacent indent Igor Russkikh
2020-08-21 19:40 ` Jesse Brandeburg
2020-08-20 18:52 ` [PATCH v6 net-next 10/10] qede: make driver reliable on unload after failures Igor Russkikh
2020-08-21 19:54 ` Jesse Brandeburg [this message]
2020-08-21 20:37 ` [EXT] Re: [PATCH v6 net-next 00/10] qed: introduce devlink health support Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821125410.00005c08@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=mkalderon@marvell.com \
--cc=netdev@vger.kernel.org \
--subject='Re: [PATCH v6 net-next 00/10] qed: introduce devlink health support' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).