Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Roman Gushchin <guro@fb.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, <kernel-team@fb.com>,
<linux-kernel@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeelb@google.com>, <linux-mm@kvack.org>
Subject: Re: [PATCH bpf-next v4 28/30] bpf: eliminate rlimit-based memory accounting infra for bpf maps
Date: Fri, 21 Aug 2020 16:15:18 -0700 [thread overview]
Message-ID: <20200821231518.GC2250889@carbon.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200821182321.dtkf5wpi4pukbq3w@ast-mbp.dhcp.thefacebook.com>
On Fri, Aug 21, 2020 at 11:23:21AM -0700, Alexei Starovoitov wrote:
> On Fri, Aug 21, 2020 at 08:01:32AM -0700, Roman Gushchin wrote:
> >
> > diff --git a/tools/testing/selftests/bpf/progs/map_ptr_kern.c b/tools/testing/selftests/bpf/progs/map_ptr_kern.c
> > index 473665cac67e..49d1dcaf7999 100644
> > --- a/tools/testing/selftests/bpf/progs/map_ptr_kern.c
> > +++ b/tools/testing/selftests/bpf/progs/map_ptr_kern.c
> > @@ -26,17 +26,12 @@ __u32 g_line = 0;
> > return 0; \
> > })
> >
> > -struct bpf_map_memory {
> > - __u32 pages;
> > -} __attribute__((preserve_access_index));
> > -
> > struct bpf_map {
> > enum bpf_map_type map_type;
> > __u32 key_size;
> > __u32 value_size;
> > __u32 max_entries;
> > __u32 id;
> > - struct bpf_map_memory memory;
> > } __attribute__((preserve_access_index));
>
> hmm. Did you build selftests?
>
> progs/map_ptr_kern.c:45:14: error: no member named 'memory' in 'struct bpf_map'
> VERIFY(map->memory.pages > 0);
> ~~~ ^
> progs/map_ptr_kern.c:25:8: note: expanded from macro 'VERIFY'
Oops, thanks, will fix in v5.
next prev parent reply other threads:[~2020-08-21 23:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 15:01 [PATCH bpf-next v4 00/30] bpf: switch to memcg-based memory accounting Roman Gushchin
2020-08-21 15:01 ` [PATCH bpf-next v4 01/30] mm: support nesting memalloc_use_memcg() Roman Gushchin
2020-08-21 16:29 ` Shakeel Butt
2020-08-21 15:01 ` [PATCH bpf-next v4 02/30] bpf: memcg-based memory accounting for bpf progs Roman Gushchin
2020-08-25 19:00 ` Shakeel Butt
2020-08-25 22:26 ` Roman Gushchin
2020-08-21 15:01 ` [PATCH bpf-next v4 03/30] bpf: memcg-based memory accounting for bpf maps Roman Gushchin
2020-08-25 23:27 ` Shakeel Butt
2020-08-26 2:38 ` Roman Gushchin
2020-08-26 8:57 ` [bpf] 3ebc0a7f46: BUG:KASAN:use-after-free_in_b kernel test robot
2020-08-21 15:01 ` [PATCH bpf-next v4 28/30] bpf: eliminate rlimit-based memory accounting infra for bpf maps Roman Gushchin
2020-08-21 18:23 ` Alexei Starovoitov
2020-08-21 23:15 ` Roman Gushchin [this message]
2020-08-21 22:20 ` [PATCH bpf-next v4 00/30] bpf: switch to memcg-based memory accounting Roman Gushchin
[not found] ` <20200821150134.2581465-5-guro@fb.com>
2020-08-27 1:19 ` [PATCH bpf-next v4 04/30] bpf: refine memcg-based memory accounting for arraymap maps Shakeel Butt
[not found] ` <20200821150134.2581465-6-guro@fb.com>
2020-08-27 1:24 ` [PATCH bpf-next v4 05/30] bpf: refine memcg-based memory accounting for cpumap maps Shakeel Butt
[not found] ` <20200821150134.2581465-7-guro@fb.com>
2020-08-27 1:25 ` [PATCH bpf-next v4 06/30] bpf: memcg-based memory accounting for cgroup storage maps Shakeel Butt
[not found] ` <20200821150134.2581465-8-guro@fb.com>
2020-08-27 1:38 ` [PATCH bpf-next v4 07/30] bpf: refine memcg-based memory accounting for devmap maps Shakeel Butt
[not found] ` <20200821150134.2581465-9-guro@fb.com>
2020-08-28 16:44 ` [PATCH bpf-next v4 08/30] bpf: refine memcg-based memory accounting for hashtab maps Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821231518.GC2250889@carbon.dhcp.thefacebook.com \
--to=guro@fb.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).