Netdev Archive on
help / color / mirror / Atom feed
From: Stephen Hemminger <>
To: "Linus Lüssing" <>
	Nikolay Aleksandrov <>,
	Roopa Prabhu <>,,,,
	"David S . Miller" <>
Subject: Re: [Bridge] [RFC PATCH net-next] bridge: Implement MLD Querier wake-up calls / Android bug workaround
Date: Sun, 23 Aug 2020 10:19:38 -0700	[thread overview]
Message-ID: <20200823101938.0f956d96@hermes.lan> (raw)
In-Reply-To: <20200823154239.GA2302@otheros>

On Sun, 23 Aug 2020 17:42:39 +0200
Linus Lüssing <> wrote:

> On Sun, Aug 16, 2020 at 03:08:13PM -0700, Stephen Hemminger wrote:
> > Rather than adding yet another feature to the bridge, could this hack be done by
> > having a BPF hook? or netfilter module?  
> Hi Stephen,
> Thanks for the constructive feedback and suggestions!
> The netfilter approach sounds tempting. However as far as I know
> OpenWrt's firewall has no easy layer 2 netfilter integration yet.
> So it has default layer 3 netfilter rules, but not for layer 2.
> Ideally I'd want to work towards a solution where things "just
> work as expected" when a user enables "IGMP Snooping" in the UI.
> I could hack the netfilter rules into netifd, the OpenWrt network
> manager, when it configures the bridge. But not sure if the
> OpenWrt maintainers would like that...
> Any preferences from the OpenWrt maintainers side?
> Regards, Linus
> PS: With BPF I don't have that much experience yet. I would need
> to write a daemon which would parse the MLD packets and would
> fetch the FDB via netlink, right? If so, sounds like that would
> need way more than 300 lines of code. And that would need to be
> maintained within OpenWrt, right?

With BPF you would need to write a small program that transforms the packet
as you want. The BPF program and the userspace program would share a
map table.  The userspace program would monitor netlink messages about
FDB and update the map. Yes it would be a few hundred lines but not huge.
The userspace could even be selective and only do it for devices where
it knows they are using the broken Android code.

Sorry, no idea how OpenWrt manages their packages.

  reply	other threads:[~2020-08-23 17:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-16 20:24 Linus Lüssing
2020-08-16 22:08 ` [Bridge] " Stephen Hemminger
2020-08-16 22:10   ` David Miller
2020-08-23 15:42   ` Linus Lüssing
2020-08-23 17:19     ` Stephen Hemminger [this message]
2020-08-23 19:49     ` Felix Fietkau
2020-08-17  4:10 ` David Miller
2020-08-17  8:39 ` Bjørn Mork
2020-08-17 13:17   ` [gluon] " Sven Eckelmann
2020-08-17 13:35     ` Bjørn Mork
2020-08-17 14:24     ` Daniel Golle
2020-08-18  0:35 ` [bridge] fdde3c8b90: WARNING:at_net/core/rtnetlink.c:#rtnl_link_register kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200823101938.0f956d96@hermes.lan \ \ \ \ \ \ \ \ \ \
    --subject='Re: [Bridge] [RFC PATCH net-next] bridge: Implement MLD Querier wake-up calls / Android bug workaround' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).