Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: gain ipv4 mtu when mtu is not locked
@ 2020-08-24 11:35 Miaohe Lin
2020-08-24 13:36 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Miaohe Lin @ 2020-08-24 11:35 UTC (permalink / raw)
To: davem, kuznet, yoshfuji, kuba; +Cc: netdev, linux-kernel, linmiaohe
When mtu is locked, we should not obtain ipv4 mtu as we return immediately
in this case and leave acquired ipv4 mtu unused.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
net/ipv4/route.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 8ca6bcab7b03..f0a0faf58267 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -1013,13 +1013,14 @@ out: kfree_skb(skb);
static void __ip_rt_update_pmtu(struct rtable *rt, struct flowi4 *fl4, u32 mtu)
{
struct dst_entry *dst = &rt->dst;
- u32 old_mtu = ipv4_mtu(dst);
+ u32 old_mtu;
struct fib_result res;
bool lock = false;
if (ip_mtu_locked(dst))
return;
+ old_mtu = ipv4_mtu(dst);
if (old_mtu < mtu)
return;
--
2.19.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: gain ipv4 mtu when mtu is not locked
2020-08-24 11:35 [PATCH] net: gain ipv4 mtu when mtu is not locked Miaohe Lin
@ 2020-08-24 13:36 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-08-24 13:36 UTC (permalink / raw)
To: linmiaohe; +Cc: kuznet, yoshfuji, kuba, netdev, linux-kernel
From: Miaohe Lin <linmiaohe@huawei.com>
Date: Mon, 24 Aug 2020 07:35:28 -0400
> When mtu is locked, we should not obtain ipv4 mtu as we return immediately
> in this case and leave acquired ipv4 mtu unused.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> net/ipv4/route.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 8ca6bcab7b03..f0a0faf58267 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -1013,13 +1013,14 @@ out: kfree_skb(skb);
> static void __ip_rt_update_pmtu(struct rtable *rt, struct flowi4 *fl4, u32 mtu)
> {
> struct dst_entry *dst = &rt->dst;
> - u32 old_mtu = ipv4_mtu(dst);
> + u32 old_mtu;
> struct fib_result res;
> bool lock = false;
Please preserve the reverse christmas tree ordering of local variables here.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-24 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 11:35 [PATCH] net: gain ipv4 mtu when mtu is not locked Miaohe Lin
2020-08-24 13:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).