Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: Avoid access icmp_err_convert when icmp code is ICMP_FRAG_NEEDED
@ 2020-08-24 11:15 Miaohe Lin
2020-08-25 1:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Miaohe Lin @ 2020-08-24 11:15 UTC (permalink / raw)
To: davem, kuznet, yoshfuji, kuba; +Cc: netdev, linux-kernel, linmiaohe
There is no need to fetch errno and fatal info from icmp_err_convert when
icmp code is ICMP_FRAG_NEEDED.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
net/ipv4/raw.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
index 6fd4330287c2..ea4c36e93824 100644
--- a/net/ipv4/raw.c
+++ b/net/ipv4/raw.c
@@ -260,11 +260,12 @@ static void raw_err(struct sock *sk, struct sk_buff *skb, u32 info)
err = EHOSTUNREACH;
if (code > NR_ICMP_UNREACH)
break;
- err = icmp_err_convert[code].errno;
- harderr = icmp_err_convert[code].fatal;
if (code == ICMP_FRAG_NEEDED) {
harderr = inet->pmtudisc != IP_PMTUDISC_DONT;
err = EMSGSIZE;
+ } else {
+ err = icmp_err_convert[code].errno;
+ harderr = icmp_err_convert[code].fatal;
}
}
--
2.19.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: Avoid access icmp_err_convert when icmp code is ICMP_FRAG_NEEDED
2020-08-24 11:15 [PATCH] net: Avoid access icmp_err_convert when icmp code is ICMP_FRAG_NEEDED Miaohe Lin
@ 2020-08-25 1:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-08-25 1:11 UTC (permalink / raw)
To: linmiaohe; +Cc: kuznet, yoshfuji, kuba, netdev, linux-kernel
From: Miaohe Lin <linmiaohe@huawei.com>
Date: Mon, 24 Aug 2020 07:15:04 -0400
> There is no need to fetch errno and fatal info from icmp_err_convert when
> icmp code is ICMP_FRAG_NEEDED.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-25 1:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 11:15 [PATCH] net: Avoid access icmp_err_convert when icmp code is ICMP_FRAG_NEEDED Miaohe Lin
2020-08-25 1:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).