Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Kurt Kanzenbach <kurt@linutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Kamil Alkhouri <kamil.alkhouri@hs-offenburg.de>,
ilias.apalodimas@linaro.org,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Po Liu <Po.Liu@nxp.com>
Subject: Re: [PATCH v3 0/8] Hirschmann Hellcreek DSA driver
Date: Tue, 25 Aug 2020 01:02:03 +0300 [thread overview]
Message-ID: <20200824220203.atjmjrydq4qyt33x@skbuf> (raw)
In-Reply-To: <20200824143110.43f4619f@kicinski-fedora-PC1C0HJN>
On Mon, Aug 24, 2020 at 02:31:10PM -0700, Jakub Kicinski wrote:
> On Thu, 20 Aug 2020 10:11:10 +0200 Kurt Kanzenbach wrote:
> > this series adds a DSA driver for the Hirschmann Hellcreek TSN switch
> > IP. Characteristics of that IP:
> >
> > * Full duplex Ethernet interface at 100/1000 Mbps on three ports
> > * IEEE 802.1Q-compliant Ethernet Switch
> > * IEEE 802.1Qbv Time-Aware scheduling support
> > * IEEE 1588 and IEEE 802.1AS support
>
> I don't see anything worth complaining about here, but this is not my
> area of expertise..
>
> DSA and TAPRIO folks - does this look good to you?
Just my comment on patch 5/8 about netdev->tc_to_txq. There are 2
distinct things about that:
- accessing struct net_device directly hurts the DSA model a little bit.
- I think there's some confusion regarding the use of netdev->tc_to_txq
itself. I don't think that's the right place to setup a VLAN PCP to
traffic class mapping. That's simply "what traffic class does each
netdev queue have". I would even go as far as say that Linux doesn't
support a VLAN PCP to TC mapping (similar to the DSCP to TC mapping
from the DCB ops) at all, except for the ingress-qos-map and
egress-qos-map of the 8021q driver, which can't be offloaded and don't
map nicely over existing hardware anyway (what hardware has an
ingress-qos-map and an egress-qos-map per individual VLAN?!).
Although I do really see the need for having a mapping between VLAN
PCP and traffic class, I would suggest Kurt to not expose this through
taprio/mqprio (hardcode the PCP mapping as 1-to-1 with TC, as other
drivers do), and let's try to come up separately with an abstraction
for that.
Thanks,
-Vladimir
next prev parent reply other threads:[~2020-08-24 22:02 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 8:11 Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 1/8] net: dsa: Add tag handling for Hirschmann Hellcreek switches Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 2/8] net: dsa: Add DSA driver " Kurt Kanzenbach
2020-08-24 22:44 ` Andrew Lunn
2020-08-25 9:07 ` Kurt Kanzenbach
2020-08-25 13:56 ` Andrew Lunn
2020-08-25 14:48 ` Kurt Kanzenbach
2020-08-27 10:29 ` Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 3/8] net: dsa: hellcreek: Add PTP clock support Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 4/8] net: dsa: hellcreek: Add support for hardware timestamping Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support Kurt Kanzenbach
2020-08-22 14:39 ` Vladimir Oltean
2020-08-24 6:10 ` Kurt Kanzenbach
2020-08-24 23:45 ` Vinicius Costa Gomes
2020-08-25 9:42 ` Kurt Kanzenbach
2020-08-25 17:58 ` Vinicius Costa Gomes
2020-08-27 10:12 ` Kurt Kanzenbach
2020-08-25 9:46 ` Vladimir Oltean
2020-08-25 10:09 ` Kurt Kanzenbach
2020-08-25 17:33 ` Vinicius Costa Gomes
2020-08-24 22:56 ` Vladimir Oltean
2020-08-25 9:33 ` Kurt Kanzenbach
2020-08-25 9:38 ` Vladimir Oltean
2020-08-25 9:55 ` Kurt Kanzenbach
2020-08-27 16:25 ` Richard Cochran
2020-08-28 12:31 ` Kurt Kanzenbach
2020-08-24 23:57 ` Vinicius Costa Gomes
2020-08-25 9:23 ` Kurt Kanzenbach
2020-08-25 9:32 ` Vladimir Oltean
2020-09-01 14:20 ` Kurt Kanzenbach
2020-09-01 14:47 ` Vladimir Oltean
2020-08-25 17:50 ` Vinicius Costa Gomes
2020-08-20 8:11 ` [PATCH v3 6/8] net: dsa: hellcreek: Add PTP status LEDs Kurt Kanzenbach
2020-08-24 22:50 ` Andrew Lunn
2020-08-20 8:11 ` [PATCH v3 7/8] dt-bindings: Add vendor prefix for Hirschmann Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 8/8] dt-bindings: net: dsa: Add documentation for Hellcreek switches Kurt Kanzenbach
2020-08-24 22:52 ` Andrew Lunn
2020-08-25 22:28 ` Rob Herring
2020-08-24 21:31 ` [PATCH v3 0/8] Hirschmann Hellcreek DSA driver Jakub Kicinski
2020-08-24 22:02 ` Vladimir Oltean [this message]
2020-08-24 22:35 ` David Miller
2020-08-24 22:57 ` Vladimir Oltean
2020-08-25 11:21 ` Kurt Kanzenbach
2020-08-25 17:14 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824220203.atjmjrydq4qyt33x@skbuf \
--to=olteanv@gmail.com \
--cc=Po.Liu@nxp.com \
--cc=andrew@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ivan.khoronzhuk@linaro.org \
--cc=kamil.alkhouri@hs-offenburg.de \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vinicius.gomes@intel.com \
--cc=vivien.didelot@gmail.com \
--cc=xiaoliang.yang_1@nxp.com \
--subject='Re: [PATCH v3 0/8] Hirschmann Hellcreek DSA driver' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).