Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Kamil Alkhouri <kamil.alkhouri@hs-offenburg.de>,
ilias.apalodimas@linaro.org
Subject: Re: [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support
Date: Tue, 25 Aug 2020 12:32:19 +0300 [thread overview]
Message-ID: <20200825093219.bybzzpyfbbccjanf@skbuf> (raw)
In-Reply-To: <87bliz13kj.fsf@kurt>
On Tue, Aug 25, 2020 at 11:23:56AM +0200, Kurt Kanzenbach wrote:
> On Mon Aug 24 2020, Vinicius Costa Gomes wrote:
> > Hi,
> >
> > Kurt Kanzenbach <kurt@linutronix.de> writes:
> >
> [snip]
> >> + /* Setup timer for schedule switch: The IP core only allows to set a
> >> + * cycle start timer 8 seconds in the future. This is why we setup the
> >> + * hritmer to base_time - 5 seconds. Then, we have enough time to
> >> + * activate IP core's EST timer.
> >> + */
> >> + start = ktime_sub_ns(schedule->base_time, (u64)5 * NSEC_PER_SEC);
> >> + hrtimer_start_range_ns(&hellcreek_port->cycle_start_timer, start,
> >> + NSEC_PER_SEC, HRTIMER_MODE_ABS);
> >
> > If we are talking about seconds here, I don't think you need to use a
> > hrtimer, you could use a workqueue/delayed_work. Should make things a
> > bit simpler.
>
> I've used hrtimers for one reason: The hrtimer provides a way to fire at
> an absolute base time based on CLOCK_TAI. All the other facilities such
> as workqueues, timer list timers, etc do not.
That still doesn't justify the complexity of irqsave spinlocks and such.
You could just as well schedule a workqueue from that hrtimer and have
process context...
Thanks,
-Vladimir
next prev parent reply other threads:[~2020-08-25 9:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 8:11 [PATCH v3 0/8] Hirschmann Hellcreek DSA driver Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 1/8] net: dsa: Add tag handling for Hirschmann Hellcreek switches Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 2/8] net: dsa: Add DSA driver " Kurt Kanzenbach
2020-08-24 22:44 ` Andrew Lunn
2020-08-25 9:07 ` Kurt Kanzenbach
2020-08-25 13:56 ` Andrew Lunn
2020-08-25 14:48 ` Kurt Kanzenbach
2020-08-27 10:29 ` Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 3/8] net: dsa: hellcreek: Add PTP clock support Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 4/8] net: dsa: hellcreek: Add support for hardware timestamping Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support Kurt Kanzenbach
2020-08-22 14:39 ` Vladimir Oltean
2020-08-24 6:10 ` Kurt Kanzenbach
2020-08-24 23:45 ` Vinicius Costa Gomes
2020-08-25 9:42 ` Kurt Kanzenbach
2020-08-25 17:58 ` Vinicius Costa Gomes
2020-08-27 10:12 ` Kurt Kanzenbach
2020-08-25 9:46 ` Vladimir Oltean
2020-08-25 10:09 ` Kurt Kanzenbach
2020-08-25 17:33 ` Vinicius Costa Gomes
2020-08-24 22:56 ` Vladimir Oltean
2020-08-25 9:33 ` Kurt Kanzenbach
2020-08-25 9:38 ` Vladimir Oltean
2020-08-25 9:55 ` Kurt Kanzenbach
2020-08-27 16:25 ` Richard Cochran
2020-08-28 12:31 ` Kurt Kanzenbach
2020-08-24 23:57 ` Vinicius Costa Gomes
2020-08-25 9:23 ` Kurt Kanzenbach
2020-08-25 9:32 ` Vladimir Oltean [this message]
2020-09-01 14:20 ` Kurt Kanzenbach
2020-09-01 14:47 ` Vladimir Oltean
2020-08-25 17:50 ` Vinicius Costa Gomes
2020-08-20 8:11 ` [PATCH v3 6/8] net: dsa: hellcreek: Add PTP status LEDs Kurt Kanzenbach
2020-08-24 22:50 ` Andrew Lunn
2020-08-20 8:11 ` [PATCH v3 7/8] dt-bindings: Add vendor prefix for Hirschmann Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 8/8] dt-bindings: net: dsa: Add documentation for Hellcreek switches Kurt Kanzenbach
2020-08-24 22:52 ` Andrew Lunn
2020-08-25 22:28 ` Rob Herring
2020-08-24 21:31 ` [PATCH v3 0/8] Hirschmann Hellcreek DSA driver Jakub Kicinski
2020-08-24 22:02 ` Vladimir Oltean
2020-08-24 22:35 ` David Miller
2020-08-24 22:57 ` Vladimir Oltean
2020-08-25 11:21 ` Kurt Kanzenbach
2020-08-25 17:14 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825093219.bybzzpyfbbccjanf@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kamil.alkhouri@hs-offenburg.de \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vinicius.gomes@intel.com \
--cc=vivien.didelot@gmail.com \
--subject='Re: [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).