Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Armin Wolf <W_Armin@gmx.de>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: [PATCH 0/2 v3 net-next] 8390: core cleanups
Date: Sat, 29 Aug 2020 13:17:32 +0200	[thread overview]
Message-ID: <20200829111701.GA9219@mx-linux-amd> (raw)

The purpose of this patchset is to do some
cleanups in lib8390.c and 8390.c.

While most changes are coding-style related,
pr_cont() usage in lib8390.c was replaced by
a more SMP-safe construct.

Other functional changes include the removal of
version-printing in lib8390.c so modules using lib8390.c
do not need a global version-string in order to compile
successfully.

Patches do compile and run flawless on 5.9.0-rc1 with
a RTL8029AS nic using ne2k-pci.

v3 changes:
- swap commits to not break buildability (sorry)
- move MODULE_LICENCE at the bottom and remove MODULE_VERSION in 8390.c

v2 changes:
- change "librarys" to "libraries" in 8390.c commit
- improve 8390.c commit
- prevent uneven whitespaces in error message (lib8390.c)
- do not destroy kernel doc comments in lib8390.c
- fix some typos in lib8390.c

Armin Wolf (2):
  lib8390: Fix coding-style issues and remove verion printing
  8390: Miscellaneous cleanups

 drivers/net/ethernet/8390/8390.c    |  21 +-
 drivers/net/ethernet/8390/lib8390.c | 590 ++++++++++++++--------------
 2 files changed, 308 insertions(+), 303 deletions(-)

--
2.20.1


             reply	other threads:[~2020-08-29 11:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-29 11:17 Armin Wolf [this message]
2020-08-31 19:36 ` David Miller
2020-08-31 19:37   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200829111701.GA9219@mx-linux-amd \
    --to=w_armin@gmx.de \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH 0/2 v3 net-next] 8390: core cleanups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).