Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rustam Kovhaev <rkovhaev@gmail.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
Rustam Kovhaev <rkovhaev@gmail.com>
Subject: [PATCH] veth: fix memory leak in veth_newlink()
Date: Sun, 30 Aug 2020 06:13:36 -0700 [thread overview]
Message-ID: <20200830131336.275844-1-rkovhaev@gmail.com> (raw)
when register_netdevice(dev) fails we should check whether struct
veth_rq has been allocated via ndo_init callback and free it, because,
depending on the code path, register_netdevice() might not call
priv_destructor() callback
Reported-and-tested-by: syzbot+59ef240dd8f0ed7598a8@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=59ef240dd8f0ed7598a8
Signed-off-by: Rustam Kovhaev <rkovhaev@gmail.com>
---
drivers/net/veth.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index a475f48d43c4..e40ca62a046a 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -1394,7 +1394,9 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
return 0;
err_register_dev:
- /* nothing to do */
+ priv = netdev_priv(dev);
+ if (priv->rq)
+ veth_dev_free(dev);
err_configure_peer:
unregister_netdevice(peer);
return err;
--
2.28.0
next reply other threads:[~2020-08-30 13:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 13:13 Rustam Kovhaev [this message]
2020-08-31 0:16 ` [PATCH] veth: fix memory leak in veth_newlink() Toshiaki Makita
2020-08-31 0:51 ` Rustam Kovhaev
2020-08-31 1:43 ` Toshiaki Makita
2020-09-01 20:01 ` David Miller
2020-09-01 22:59 ` Rustam Kovhaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200830131336.275844-1-rkovhaev@gmail.com \
--to=rkovhaev@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).