Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net-next v2 0/2] Add ip6_fragment in ipv6_stub
@ 2020-08-28 15:14 wenxu
  2020-08-28 15:14 ` [PATCH net-next v2 1/2] ipv6: add ipv6_fragment hook " wenxu
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: wenxu @ 2020-08-28 15:14 UTC (permalink / raw)
  To: netdev

From: wenxu <wenxu@ucloud.cn>

Add ip6_fragment in ipv6_stub and use it in openvswitch
This version add default function eafnosupport_ipv6_fragment

wenxu (2):
  ipv6: add ipv6_fragment hook in ipv6_stub
  openvswitch: using ip6_fragment in ipv6_stub

 include/net/ipv6_stubs.h  | 3 +++
 net/ipv6/addrconf_core.c  | 8 ++++++++
 net/ipv6/af_inet6.c       | 1 +
 net/openvswitch/actions.c | 7 +------
 4 files changed, 13 insertions(+), 6 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH net-next v2 1/2] ipv6: add ipv6_fragment hook in ipv6_stub
  2020-08-28 15:14 [PATCH net-next v2 0/2] Add ip6_fragment in ipv6_stub wenxu
@ 2020-08-28 15:14 ` wenxu
  2020-08-28 15:14 ` [PATCH net-next v2 2/2] openvswitch: using ip6_fragment " wenxu
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: wenxu @ 2020-08-28 15:14 UTC (permalink / raw)
  To: netdev

From: wenxu <wenxu@ucloud.cn>

Add ipv6_fragment to ipv6_stub to avoid calling netfilter when
access ip6_fragment.

Signed-off-by: wenxu <wenxu@ucloud.cn>
---
v2: add default one eafnosupport_ipv6_fragment

 include/net/ipv6_stubs.h | 3 +++
 net/ipv6/addrconf_core.c | 8 ++++++++
 net/ipv6/af_inet6.c      | 1 +
 3 files changed, 12 insertions(+)

diff --git a/include/net/ipv6_stubs.h b/include/net/ipv6_stubs.h
index d7a7f7c..8fce558 100644
--- a/include/net/ipv6_stubs.h
+++ b/include/net/ipv6_stubs.h
@@ -63,6 +63,9 @@ struct ipv6_stub {
 			       int encap_type);
 #endif
 	struct neigh_table *nd_tbl;
+
+	int (*ipv6_fragment)(struct net *net, struct sock *sk, struct sk_buff *skb,
+			     int (*output)(struct net *, struct sock *, struct sk_buff *));
 };
 extern const struct ipv6_stub *ipv6_stub __read_mostly;
 
diff --git a/net/ipv6/addrconf_core.c b/net/ipv6/addrconf_core.c
index 9ebf3fe..c70c192 100644
--- a/net/ipv6/addrconf_core.c
+++ b/net/ipv6/addrconf_core.c
@@ -191,6 +191,13 @@ static int eafnosupport_ip6_del_rt(struct net *net, struct fib6_info *rt,
 	return -EAFNOSUPPORT;
 }
 
+static int eafnosupport_ipv6_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
+				      int (*output)(struct net *, struct sock *, struct sk_buff *))
+{
+	kfree_skb(skb);
+	return -EAFNOSUPPORT;
+}
+
 const struct ipv6_stub *ipv6_stub __read_mostly = &(struct ipv6_stub) {
 	.ipv6_dst_lookup_flow = eafnosupport_ipv6_dst_lookup_flow,
 	.ipv6_route_input  = eafnosupport_ipv6_route_input,
@@ -201,6 +208,7 @@ static int eafnosupport_ip6_del_rt(struct net *net, struct fib6_info *rt,
 	.ip6_mtu_from_fib6 = eafnosupport_ip6_mtu_from_fib6,
 	.fib6_nh_init	   = eafnosupport_fib6_nh_init,
 	.ip6_del_rt	   = eafnosupport_ip6_del_rt,
+	.ipv6_fragment	   = eafnosupport_ipv6_fragment,
 };
 EXPORT_SYMBOL_GPL(ipv6_stub);
 
diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
index d9a1493..e648fbe 100644
--- a/net/ipv6/af_inet6.c
+++ b/net/ipv6/af_inet6.c
@@ -1027,6 +1027,7 @@ static int ipv6_route_input(struct sk_buff *skb)
 	.xfrm6_rcv_encap = xfrm6_rcv_encap,
 #endif
 	.nd_tbl	= &nd_tbl,
+	.ipv6_fragment = ip6_fragment,
 };
 
 static const struct ipv6_bpf_stub ipv6_bpf_stub_impl = {
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH net-next v2 2/2] openvswitch: using ip6_fragment in ipv6_stub
  2020-08-28 15:14 [PATCH net-next v2 0/2] Add ip6_fragment in ipv6_stub wenxu
  2020-08-28 15:14 ` [PATCH net-next v2 1/2] ipv6: add ipv6_fragment hook " wenxu
@ 2020-08-28 15:14 ` wenxu
  2020-08-29  1:49 ` [PATCH net-next v2 0/2] Add " Marcelo Ricardo Leitner
  2020-08-31 19:26 ` David Miller
  3 siblings, 0 replies; 5+ messages in thread
From: wenxu @ 2020-08-28 15:14 UTC (permalink / raw)
  To: netdev

From: wenxu <wenxu@ucloud.cn>

Using ipv6_stub->ipv6_fragment to avoid the netfilter dependency

Signed-off-by: wenxu <wenxu@ucloud.cn>
---
 net/openvswitch/actions.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
index 2611657..fd34089 100644
--- a/net/openvswitch/actions.c
+++ b/net/openvswitch/actions.c
@@ -9,7 +9,6 @@
 #include <linux/in.h>
 #include <linux/ip.h>
 #include <linux/openvswitch.h>
-#include <linux/netfilter_ipv6.h>
 #include <linux/sctp.h>
 #include <linux/tcp.h>
 #include <linux/udp.h>
@@ -848,13 +847,9 @@ static void ovs_fragment(struct net *net, struct vport *vport,
 		ip_do_fragment(net, skb->sk, skb, ovs_vport_output);
 		refdst_drop(orig_dst);
 	} else if (key->eth.type == htons(ETH_P_IPV6)) {
-		const struct nf_ipv6_ops *v6ops = nf_get_ipv6_ops();
 		unsigned long orig_dst;
 		struct rt6_info ovs_rt;
 
-		if (!v6ops)
-			goto err;
-
 		prepare_frag(vport, skb, orig_network_offset,
 			     ovs_key_mac_proto(key));
 		memset(&ovs_rt, 0, sizeof(ovs_rt));
@@ -866,7 +861,7 @@ static void ovs_fragment(struct net *net, struct vport *vport,
 		skb_dst_set_noref(skb, &ovs_rt.dst);
 		IP6CB(skb)->frag_max_size = mru;
 
-		v6ops->fragment(net, skb->sk, skb, ovs_vport_output);
+		ipv6_stub->ipv6_fragment(net, skb->sk, skb, ovs_vport_output);
 		refdst_drop(orig_dst);
 	} else {
 		WARN_ONCE(1, "Failed fragment ->%s: eth=%04x, MRU=%d, MTU=%d.",
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next v2 0/2] Add ip6_fragment in ipv6_stub
  2020-08-28 15:14 [PATCH net-next v2 0/2] Add ip6_fragment in ipv6_stub wenxu
  2020-08-28 15:14 ` [PATCH net-next v2 1/2] ipv6: add ipv6_fragment hook " wenxu
  2020-08-28 15:14 ` [PATCH net-next v2 2/2] openvswitch: using ip6_fragment " wenxu
@ 2020-08-29  1:49 ` Marcelo Ricardo Leitner
  2020-08-31 19:26 ` David Miller
  3 siblings, 0 replies; 5+ messages in thread
From: Marcelo Ricardo Leitner @ 2020-08-29  1:49 UTC (permalink / raw)
  To: wenxu; +Cc: netdev

On Fri, Aug 28, 2020 at 11:14:30PM +0800, wenxu@ucloud.cn wrote:
> From: wenxu <wenxu@ucloud.cn>
> 
> Add ip6_fragment in ipv6_stub and use it in openvswitch
> This version add default function eafnosupport_ipv6_fragment

Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next v2 0/2] Add ip6_fragment in ipv6_stub
  2020-08-28 15:14 [PATCH net-next v2 0/2] Add ip6_fragment in ipv6_stub wenxu
                   ` (2 preceding siblings ...)
  2020-08-29  1:49 ` [PATCH net-next v2 0/2] Add " Marcelo Ricardo Leitner
@ 2020-08-31 19:26 ` David Miller
  3 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2020-08-31 19:26 UTC (permalink / raw)
  To: wenxu; +Cc: netdev

From: wenxu@ucloud.cn
Date: Fri, 28 Aug 2020 23:14:30 +0800

> From: wenxu <wenxu@ucloud.cn>
> 
> Add ip6_fragment in ipv6_stub and use it in openvswitch
> This version add default function eafnosupport_ipv6_fragment

Seires applied, thank you.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-08-31 19:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-28 15:14 [PATCH net-next v2 0/2] Add ip6_fragment in ipv6_stub wenxu
2020-08-28 15:14 ` [PATCH net-next v2 1/2] ipv6: add ipv6_fragment hook " wenxu
2020-08-28 15:14 ` [PATCH net-next v2 2/2] openvswitch: using ip6_fragment " wenxu
2020-08-29  1:49 ` [PATCH net-next v2 0/2] Add " Marcelo Ricardo Leitner
2020-08-31 19:26 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).