Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: W_Armin@gmx.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/2 v3 net-next] 8390: core cleanups
Date: Mon, 31 Aug 2020 12:37:10 -0700 (PDT)	[thread overview]
Message-ID: <20200831.123710.140170643696361053.davem@davemloft.net> (raw)
In-Reply-To: <20200831.123621.1837178929086250340.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Mon, 31 Aug 2020 12:36:21 -0700 (PDT)

> From: Armin Wolf <W_Armin@gmx.de>
> Date: Sat, 29 Aug 2020 13:17:32 +0200
> 
>> The purpose of this patchset is to do some
>> cleanups in lib8390.c and 8390.c.
>> 
>> While most changes are coding-style related,
>> pr_cont() usage in lib8390.c was replaced by
>> a more SMP-safe construct.
>> 
>> Other functional changes include the removal of
>> version-printing in lib8390.c so modules using lib8390.c
>> do not need a global version-string in order to compile
>> successfully.
>> 
>> Patches do compile and run flawless on 5.9.0-rc1 with
>> a RTL8029AS nic using ne2k-pci.
>  ...
> 
> Series applied to net-next.

Actually reverted, this adds a new build warning:

drivers/net/ethernet/8390/ax88796.c:58:22: warning: ‘version’ defined but not used [-Wunused-variable]
   58 | static unsigned char version[] = "ax88796.c: Copyright 2005,2007 Simtec Electronics\n";
      |                      ^~~~~~~
  C-c C-cmake[2]: *** Deleting file 'net/sunrpc/auth.o'

      reply	other threads:[~2020-08-31 19:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-29 11:17 Armin Wolf
2020-08-31 19:36 ` David Miller
2020-08-31 19:37   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200831.123710.140170643696361053.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=W_Armin@gmx.de \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH 0/2 v3 net-next] 8390: core cleanups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).