Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: ethernet: ti: am65-cpsw: fix rmii 100Mbit link mode
@ 2020-08-30 17:34 Grygorii Strashko
  2020-08-31 20:07 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Grygorii Strashko @ 2020-08-30 17:34 UTC (permalink / raw)
  To: David S. Miller, Jakub Kicinski, netdev
  Cc: linux-kernel, linux-arm-kernel, Vignesh Raghavendra, Grygorii Strashko

In RMII link mode it's required to set bit 15 IFCTL_A in MAC_SL MAC_CONTROL
register to enable support for 100Mbit link speed.

Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index cb994f66c3be..9baf3f3da91e 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -174,6 +174,8 @@ void am65_cpsw_nuss_adjust_link(struct net_device *ndev)
 		if (phy->speed == 10 && phy_interface_is_rgmii(phy))
 			/* Can be used with in band mode only */
 			mac_control |= CPSW_SL_CTL_EXT_EN;
+		if (phy->speed == 100 && phy->interface == PHY_INTERFACE_MODE_RMII)
+			mac_control |= CPSW_SL_CTL_IFCTL_A;
 		if (phy->duplex)
 			mac_control |= CPSW_SL_CTL_FULLDUPLEX;
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: ethernet: ti: am65-cpsw: fix rmii 100Mbit link mode
  2020-08-30 17:34 [PATCH] net: ethernet: ti: am65-cpsw: fix rmii 100Mbit link mode Grygorii Strashko
@ 2020-08-31 20:07 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-08-31 20:07 UTC (permalink / raw)
  To: grygorii.strashko; +Cc: kuba, netdev, linux-kernel, linux-arm-kernel, vigneshr

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Sun, 30 Aug 2020 20:34:32 +0300

> In RMII link mode it's required to set bit 15 IFCTL_A in MAC_SL MAC_CONTROL
> register to enable support for 100Mbit link speed.
> 
> Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Applied and queued up for v5.7+ -stable, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-31 20:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-30 17:34 [PATCH] net: ethernet: ti: am65-cpsw: fix rmii 100Mbit link mode Grygorii Strashko
2020-08-31 20:07 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).