From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0202C433E2 for ; Mon, 31 Aug 2020 15:52:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88FC020767 for ; Mon, 31 Aug 2020 15:52:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="AQjMHMN5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728464AbgHaPwF (ORCPT ); Mon, 31 Aug 2020 11:52:05 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:10855 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727799AbgHaPwC (ORCPT ); Mon, 31 Aug 2020 11:52:02 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1598889121; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=UiCtEuXB1/ghowuh3jHXLuUWPllC4130UQOUkOzWhjg=; b=AQjMHMN5kLIQv0ozvoWwyATpU2HZbTvAatiOrGUYeIN59xgzHiPUS6+27Un1ztfsbeY2Vgar I8v9vSrPPds+fVJ8eBgmi6h0Rq7KL9qZcUCRXQMp2SQFGTgJ80am1g+RbYBa79qRbAocGIXv gpx4xgWPYxENRIjhlru1Npc6S6I= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 5f4d1c979bdf68cc0373e20d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 31 Aug 2020 15:51:51 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 0DCB5C4339C; Mon, 31 Aug 2020 15:51:51 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 22DADC433CA; Mon, 31 Aug 2020 15:51:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 22DADC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH 16/28] wireless: marvell: mwifiex: init: Move 'tos_to_tid_inv' to where it's used From: Kalle Valo In-Reply-To: <20200819072402.3085022-17-lee.jones@linaro.org> References: <20200819072402.3085022-17-lee.jones@linaro.org> To: Lee Jones Cc: davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200831155151.0DCB5C4339C@smtp.codeaurora.org> Date: Mon, 31 Aug 2020 15:51:51 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Lee Jones wrote: > 'tos_to_tid_inv' is only used in 2 of 17 files it's current being > included into. > > Fixes the following W=1 kernel build warning(s): > > In file included from drivers/net/wireless/marvell/mwifiex/main.c:23: > In file included from drivers/net/wireless/marvell/mwifiex/cmdevt.c:26: > In file included from drivers/net/wireless/marvell/mwifiex/util.c:25: > In file included from drivers/net/wireless/marvell/mwifiex/txrx.c:25: > In file included from drivers/net/wireless/marvell/mwifiex/11n.c:25: > In file included from drivers/net/wireless/marvell/mwifiex/wmm.c:25: > In file included from drivers/net/wireless/marvell/mwifiex/11n_aggr.c:25: > In file included from drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c:25: > In file included from drivers/net/wireless/marvell/mwifiex/join.c:25: > In file included from drivers/net/wireless/marvell/mwifiex/sta_cmd.c:25: > In file included from drivers/net/wireless/marvell/mwifiex/sta_ioctl.c:25: > In file included from drivers/net/wireless/marvell/mwifiex/sta_event.c:25: > In file included from drivers/net/wireless/marvell/mwifiex/uap_txrx.c:23: > In file included from drivers/net/wireless/marvell/mwifiex/sdio.c:27: > In file included from drivers/net/wireless/marvell/mwifiex/sta_tx.c:25: > drivers/net/wireless/marvell/mwifiex/wmm.h:41:17: warning: ‘tos_to_tid_inv’ defined but not used [-Wunused-const-variable=] > 41 | static const u8 tos_to_tid_inv[] = { > > NB: Snipped for brevity > > Cc: Amitkumar Karwar > Cc: Ganapathi Bhat > Cc: Xinming Hu > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Lee Jones The patch creates two duplicate arrays, this makes it worse than it was before. Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/11723177/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches