Netdev Archive on
help / color / mirror / Atom feed
From: David Miller <>
Subject: Re: [net-next v2 1/4] tipc: optimize key switching time and logic
Date: Tue, 01 Sep 2020 15:10:28 -0700 (PDT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: Tuong Lien <>
Date: Mon, 31 Aug 2020 15:38:14 +0700

> We reduce the lasting time for a pending TX key to be active as well as
> for a passive RX key to be freed which generally helps speed up the key
> switching. It is not expected to be too fast but should not be too slow
> either. Also the key handling logic is simplified that a pending RX key
> will be removed automatically if it is found not working after a number
> of times; the probing for a pending TX key is now carried on a specific
> message user ('LINK_PROTOCOL' or 'LINK_CONFIG') which is more efficient
> than using a timer on broadcast messages, the timer is reserved for use
> later as needed.
> The kernel logs or 'pr***()' are now made as clear as possible to user.
> Some prints are added, removed or changed to the debug-level. The
> 'TIPC_CRYPTO_DEBUG' definition is removed, and the 'pr_debug()' is used
> instead which will be much helpful in runtime.
> Besides we also optimize the code in some other places as a preparation
> for later commits.
> This commit does not change the en/decryption functionalities.
> Acked-by: Jon Maloy <>
> Signed-off-by: Tuong Lien <>

Random log messages in response to user config requests are
inappropriate especially with netlink.

Report such informational responses to errors using the
genl_info->extack instead, as is standard practice across
the entire kernel.

Please remove all kernel log messages that get emitted due to
netlink operations and use extack notifications instead.

I also disagree with the commit message stating:

	This commit does not change the en/decryption functionalities.

You are changing timer lengths and other aspects of crypto behavior,
so the patch is in fact changing things.

  reply	other threads:[~2020-09-01 22:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31  8:38 [net-next v2 0/4] tipc: add more features to TIPC encryption Tuong Lien
2020-08-31  8:38 ` [net-next v2 1/4] tipc: optimize key switching time and logic Tuong Lien
2020-09-01 22:10   ` David Miller [this message]
2020-09-02  6:16     ` Tuong Tong Lien
2020-09-02 19:49       ` David Miller
2020-08-31  8:38 ` [net-next v2 2/4] tipc: introduce encryption master key Tuong Lien
2020-08-31  8:38 ` [net-next v2 3/4] tipc: add automatic session key exchange Tuong Lien
2020-08-31  8:38 ` [net-next v2 4/4] tipc: add automatic rekeying for encryption key Tuong Lien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [net-next v2 1/4] tipc: optimize key switching time and logic' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).