From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8C95C433E2 for ; Tue, 1 Sep 2020 22:34:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C11D206EF for ; Tue, 1 Sep 2020 22:34:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727973AbgIAWeo (ORCPT ); Tue, 1 Sep 2020 18:34:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726355AbgIAWeo (ORCPT ); Tue, 1 Sep 2020 18:34:44 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C86BC061244 for ; Tue, 1 Sep 2020 15:34:44 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 50DEA13659456; Tue, 1 Sep 2020 15:17:57 -0700 (PDT) Date: Tue, 01 Sep 2020 15:34:19 -0700 (PDT) Message-Id: <20200901.153419.1567972938274024697.davem@davemloft.net> To: andrew@lunn.ch Cc: netdev@vger.kernel.org, andy.shevchenko@gmail.com Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: Fix W=1 warning with !CONFIG_OF From: David Miller In-Reply-To: <20200901023257.3030231-1-andrew@lunn.ch> References: <20200901023257.3030231-1-andrew@lunn.ch> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Tue, 01 Sep 2020 15:17:57 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andrew Lunn Date: Tue, 1 Sep 2020 04:32:57 +0200 > When building on platforms without device tree, e.g. amd64, W=1 gives > a warning about mv88e6xxx_mdio_external_match being unused. Replace > of_match_node() with of_device_is_compatible() to prevent this > warning. > > Suggested-by: Andy Shevchenko > Signed-off-by: Andrew Lunn Applied, thanks Andrew.