Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net-next] vhost: fix typo in error message
@ 2020-09-01  2:39 Yunsheng Lin
  2020-09-01  3:06 ` Jason Wang
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Yunsheng Lin @ 2020-09-01  2:39 UTC (permalink / raw)
  To: mst, jasowang; +Cc: kvm, virtualization, netdev, linux-kernel, linuxarm

"enable" should be "disable" when the function name is
vhost_disable_notify(), which does the disabling work.

Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
---
 drivers/vhost/vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 5857d4e..b45519c 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -2537,7 +2537,7 @@ void vhost_disable_notify(struct vhost_dev *dev, struct vhost_virtqueue *vq)
 	if (!vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) {
 		r = vhost_update_used_flags(vq);
 		if (r)
-			vq_err(vq, "Failed to enable notification at %p: %d\n",
+			vq_err(vq, "Failed to disable notification at %p: %d\n",
 			       &vq->used->flags, r);
 	}
 }
-- 
2.8.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] vhost: fix typo in error message
  2020-09-01  2:39 [PATCH net-next] vhost: fix typo in error message Yunsheng Lin
@ 2020-09-01  3:06 ` Jason Wang
  2020-09-01 11:14 ` Michael S. Tsirkin
  2020-09-01 22:35 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2020-09-01  3:06 UTC (permalink / raw)
  To: Yunsheng Lin, mst; +Cc: kvm, virtualization, netdev, linux-kernel, linuxarm


On 2020/9/1 上午10:39, Yunsheng Lin wrote:
> "enable" should be "disable" when the function name is
> vhost_disable_notify(), which does the disabling work.
>
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
> ---
>   drivers/vhost/vhost.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index 5857d4e..b45519c 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -2537,7 +2537,7 @@ void vhost_disable_notify(struct vhost_dev *dev, struct vhost_virtqueue *vq)
>   	if (!vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) {
>   		r = vhost_update_used_flags(vq);
>   		if (r)
> -			vq_err(vq, "Failed to enable notification at %p: %d\n",
> +			vq_err(vq, "Failed to disable notification at %p: %d\n",
>   			       &vq->used->flags, r);
>   	}
>   }


Acked-by: Jason Wang <jasowang@redhat.com>




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] vhost: fix typo in error message
  2020-09-01  2:39 [PATCH net-next] vhost: fix typo in error message Yunsheng Lin
  2020-09-01  3:06 ` Jason Wang
@ 2020-09-01 11:14 ` Michael S. Tsirkin
  2020-09-01 22:35 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2020-09-01 11:14 UTC (permalink / raw)
  To: Yunsheng Lin
  Cc: jasowang, kvm, virtualization, netdev, linux-kernel, linuxarm

On Tue, Sep 01, 2020 at 10:39:09AM +0800, Yunsheng Lin wrote:
> "enable" should be "disable" when the function name is
> vhost_disable_notify(), which does the disabling work.
> 
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

Why net-next though? It's a bugfix, can go into net.


> ---
>  drivers/vhost/vhost.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index 5857d4e..b45519c 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -2537,7 +2537,7 @@ void vhost_disable_notify(struct vhost_dev *dev, struct vhost_virtqueue *vq)
>  	if (!vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) {
>  		r = vhost_update_used_flags(vq);
>  		if (r)
> -			vq_err(vq, "Failed to enable notification at %p: %d\n",
> +			vq_err(vq, "Failed to disable notification at %p: %d\n",
>  			       &vq->used->flags, r);
>  	}
>  }
> -- 
> 2.8.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] vhost: fix typo in error message
  2020-09-01  2:39 [PATCH net-next] vhost: fix typo in error message Yunsheng Lin
  2020-09-01  3:06 ` Jason Wang
  2020-09-01 11:14 ` Michael S. Tsirkin
@ 2020-09-01 22:35 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-09-01 22:35 UTC (permalink / raw)
  To: linyunsheng
  Cc: mst, jasowang, kvm, virtualization, netdev, linux-kernel, linuxarm

From: Yunsheng Lin <linyunsheng@huawei.com>
Date: Tue, 1 Sep 2020 10:39:09 +0800

> "enable" should be "disable" when the function name is
> vhost_disable_notify(), which does the disabling work.
> 
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>

Applied to 'net'.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-01 22:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-01  2:39 [PATCH net-next] vhost: fix typo in error message Yunsheng Lin
2020-09-01  3:06 ` Jason Wang
2020-09-01 11:14 ` Michael S. Tsirkin
2020-09-01 22:35 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).