Netdev Archive on
help / color / mirror / Atom feed
From: Kalle Valo <>
To: Jia-Ju Bai <>
	Jia-Ju Bai <>
Subject: Re: p54: avoid accessing the data mapped to streaming DMA
Date: Tue,  1 Sep 2020 09:34:04 +0000 (UTC)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Jia-Ju Bai <> wrote:

> In p54p_tx(), skb->data is mapped to streaming DMA on line 337:
>   mapping = pci_map_single(..., skb->data, ...);
> Then skb->data is accessed on line 349:
>   desc->device_addr = ((struct p54_hdr *)skb->data)->req_id;
> This access may cause data inconsistency between CPU cache and hardware.
> To fix this problem, ((struct p54_hdr *)skb->data)->req_id is stored in
> a local variable before DMA mapping, and then the driver accesses this
> local variable instead of skb->data.
> Cc: <>
> Signed-off-by: Jia-Ju Bai <>
> Acked-by: Christian Lamparter <>

Patch applied to wireless-drivers-next.git, thanks.

478762855b5a p54: avoid accessing the data mapped to streaming DMA


      parent reply	other threads:[~2020-09-01  9:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-02 13:29 [PATCH] " Jia-Ju Bai
2020-08-18 12:41 ` Kalle Valo
2020-09-01  9:34 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: p54: avoid accessing the data mapped to streaming DMA' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).