Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kernel-team@fb.com,
	zeil@yandex-team.ru, khlebnikov@yandex-team.ru,
	pabeni@redhat.com, Dave Marchevsky <davemarchevsky@fb.com>
Subject: Re: [PATCH net-next] net: diag: add workaround for inode truncation
Date: Tue, 1 Sep 2020 10:32:03 -0700	[thread overview]
Message-ID: <20200901103203.223bc13a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200901093613.28a36553@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On Tue, 1 Sep 2020 09:36:13 -0700 Jakub Kicinski wrote:
> On Tue, 1 Sep 2020 08:55:29 +0200 Eric Dumazet wrote:
> > On 8/31/20 4:59 PM, Jakub Kicinski wrote:  
> > > Dave reports that struct inet_diag_msg::idiag_inode is 32 bit,
> > > while inode's type is unsigned long. This leads to truncation.
> > > 
> > > Since there is nothing we can do about the size of existing
> > > fields - add a new attribute to carry 64 bit inode numbers.  
> > 
> > Last time I checked socket inode numbers were 32bit ?
> > 
> > Is there a plan changing this ?  
> 
> Ugh, you're right that appears to be a local patch :/ 
> 
> I should have checked, sorry for the noise.

Looking at get_next_ino() - it seems like the risk of overflow is very
real, no?  Should we not address this?

      reply	other threads:[~2020-09-01 17:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 23:59 Jakub Kicinski
2020-09-01  6:55 ` Eric Dumazet
2020-09-01 16:36   ` Jakub Kicinski
2020-09-01 17:32     ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200901103203.223bc13a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=davemarchevsky@fb.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kernel-team@fb.com \
    --cc=khlebnikov@yandex-team.ru \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=zeil@yandex-team.ru \
    --subject='Re: [PATCH net-next] net: diag: add workaround for inode truncation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).