Netdev Archive on lore.kernel.org help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com> To: <davem@davemloft.net>, <steffen.klassert@secunet.com>, <willemb@google.com>, <mstarovoitov@marvell.com>, <kuba@kernel.org>, <mchehab+huawei@kernel.org>, <antoine.tenart@bootlin.com>, <edumazet@google.com>, <Jason@zx2c4.com> Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linmiaohe@huawei.com> Subject: [PATCH] net: Fix some comments Date: Sat, 5 Sep 2020 05:14:48 -0400 [thread overview] Message-ID: <20200905091448.48165-1-linmiaohe@huawei.com> (raw) Since commit 8d7017fd621d ("blackhole_netdev: use blackhole_netdev to invalidate dst entries"), we use blackhole_netdev to invalidate dst entries instead of loopback device anymore. Also fix broken NETIF_F_HW_CSUM spell. Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- include/linux/netdev_features.h | 2 +- net/core/dst.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h index 2cc3cf80b49a..0b17c4322b09 100644 --- a/include/linux/netdev_features.h +++ b/include/linux/netdev_features.h @@ -193,7 +193,7 @@ static inline int find_next_netdev_feature(u64 feature, unsigned long start) #define NETIF_F_GSO_MASK (__NETIF_F_BIT(NETIF_F_GSO_LAST + 1) - \ __NETIF_F_BIT(NETIF_F_GSO_SHIFT)) -/* List of IP checksum features. Note that NETIF_F_ HW_CSUM should not be +/* List of IP checksum features. Note that NETIF_F_HW_CSUM should not be * set in features when NETIF_F_IP_CSUM or NETIF_F_IPV6_CSUM are set-- * this would be contradictory */ diff --git a/net/core/dst.c b/net/core/dst.c index d6b6ced0d451..0c01bd8d9d81 100644 --- a/net/core/dst.c +++ b/net/core/dst.c @@ -144,7 +144,7 @@ static void dst_destroy_rcu(struct rcu_head *head) /* Operations to mark dst as DEAD and clean up the net device referenced * by dst: - * 1. put the dst under loopback interface and discard all tx/rx packets + * 1. put the dst under blackhole interface and discard all tx/rx packets * on this route. * 2. release the net_device * This function should be called when removing routes from the fib tree -- 2.19.1
next reply other threads:[~2020-09-05 9:16 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-05 9:14 Miaohe Lin [this message] 2020-09-06 19:10 ` [PATCH] net: Fix some comments Jakub Kicinski -- strict thread matches above, loose matches on Subject: below -- 2020-09-07 1:37 linmiaohe 2020-08-27 11:27 Miaohe Lin 2020-08-27 15:02 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200905091448.48165-1-linmiaohe@huawei.com \ --to=linmiaohe@huawei.com \ --cc=Jason@zx2c4.com \ --cc=antoine.tenart@bootlin.com \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mchehab+huawei@kernel.org \ --cc=mstarovoitov@marvell.com \ --cc=netdev@vger.kernel.org \ --cc=steffen.klassert@secunet.com \ --cc=willemb@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).