Re: [PATCH 1/4] net: dsa: microchip: Make switch detection more informative

[Andrew Lunn <andrew@lunn.ch>]

On Sat, Sep 05, 2020 at 03:03:22PM +0100, Paul Barker wrote:
> To make switch detection more informative print the result of the
> ksz9477/ksz9893 compatibility check. With debug output enabled also
> print the contents of the Chip ID registers as a 40-bit hex string.
> 
> As this detection is the first communication with the switch performed
> by the driver, making it easy to see any errors here will help identify
> issues with SPI data corruption or reset sequencing.
> 
> Signed-off-by: Paul Barker <pbarker@konsulko.com>
> ---
>  drivers/net/dsa/microchip/ksz9477.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c
> index 3cb22d149813..a48f5edab561 100644
> --- a/drivers/net/dsa/microchip/ksz9477.c
> +++ b/drivers/net/dsa/microchip/ksz9477.c
> @@ -13,6 +13,7 @@
>  #include <linux/if_bridge.h>
>  #include <net/dsa.h>
>  #include <net/switchdev.h>
> +#include <linux/printk.h>

It is not often you see that include. linux/kernel.h includes it
anyway, and given how few files include printk.h, i doubt it will ever
be removed from kernel.h

   Andrew