Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, Vivien Didelot <vivien.didelot@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/2] net: dsa: bcm_sf2: Ensure that MDIO diversion is used
Date: Sat, 5 Sep 2020 17:37:29 +0200	[thread overview]
Message-ID: <20200905153729.GG3164319@lunn.ch> (raw)
In-Reply-To: <20200904213730.3467899-3-f.fainelli@gmail.com>

On Fri, Sep 04, 2020 at 02:37:30PM -0700, Florian Fainelli wrote:
> Registering our slave MDIO bus outside of the OF infrastructure is
> necessary in order to avoid creating double references of the same
> Device Tree nodes, however it is not sufficient to guarantee that the
> MDIO bus diversion is used because of_phy_connect() will still resolve
> to a valid PHY phandle and it will connect to the PHY using its parent
> MDIO bus which is still the SF2 master MDIO bus. The reason for that is
> because BCM7445 systems were already shipped with a Device Tree blob
> looking like this (irrelevant parts omitted for simplicity):

Hi Florian

Thanks for the extended commit message.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  reply	other threads:[~2020-09-05 15:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04 21:37 [PATCH net-next v2 0/2] net: dsa: bcm_sf2: Ensure " Florian Fainelli
2020-09-04 21:37 ` [PATCH net-next v2 1/2] of: Export of_remove_property() to modules Florian Fainelli
2020-09-04 22:16   ` Rob Herring
2020-09-04 21:37 ` [PATCH net-next v2 2/2] net: dsa: bcm_sf2: Ensure that MDIO diversion is used Florian Fainelli
2020-09-05 15:37   ` Andrew Lunn [this message]
2020-09-05 21:29 ` [PATCH net-next v2 0/2] net: dsa: bcm_sf2: Ensure " Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200905153729.GG3164319@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=frowand.list@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=vivien.didelot@gmail.com \
    --subject='Re: [PATCH net-next v2 2/2] net: dsa: bcm_sf2: Ensure that MDIO diversion is used' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).