Netdev Archive on
help / color / mirror / Atom feed
From: Armin Wolf <>
Subject: [PATCH 0/3 v4 net-next] 8390: core cleanups
Date: Sat, 5 Sep 2020 19:41:57 +0200	[thread overview]
Message-ID: <20200905174156.GA5838@mx-linux-amd> (raw)

The purpose of this patchset is to do some
cleanups in lib8390.c and 8390.c.

While most changes are coding-style related,
pr_cont() usage in lib8390.c was replaced by
a more SMP-safe construct.

Other functional changes include the removal of
version-printing in lib8390.c so modules using lib8390.c
do not need a global version-string in order to compile

Patches do compile and run flawless on 5.9.0-rc1 with
a RTL8029AS nic using ne2k-pci.

v4 changes:
- Remove unused version strings to prevent warnings

v3 changes:
- swap commits to not break buildability (sorry)
- move MODULE_LICENCE at the bottom and remove MODULE_VERSION in 8390.c

v2 changes:
- change "librarys" to "libraries" in 8390.c commit
- improve 8390.c commit
- prevent uneven whitespaces in error message (lib8390.c)
- do not destroy kernel doc comments in lib8390.c
- fix some typos in lib8390.c

Armin Wolf (3):
  lib8390: Fix coding-style issues and remove verion printing
  8390: Miscellaneous cleanups
  8390: Remove version string

 drivers/net/ethernet/8390/8390.c      |  21 +-
 drivers/net/ethernet/8390/8390p.c     |  18 +-
 drivers/net/ethernet/8390/ax88796.c   |   3 -
 drivers/net/ethernet/8390/etherh.c    |   3 -
 drivers/net/ethernet/8390/hydra.c     |   8 +-
 drivers/net/ethernet/8390/lib8390.c   | 590 +++++++++++++-------------
 drivers/net/ethernet/8390/mac8390.c   |   3 -
 drivers/net/ethernet/8390/mcf8390.c   |   3 -
 drivers/net/ethernet/8390/xsurf100.c  |   3 -
 drivers/net/ethernet/8390/zorro8390.c |   5 +-
 10 files changed, 332 insertions(+), 325 deletions(-)


                 reply	other threads:[~2020-09-05 17:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200905174156.GA5838@mx-linux-amd \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).