From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77F5AC433E2 for ; Sun, 6 Sep 2020 17:25:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C8C42078E for ; Sun, 6 Sep 2020 17:25:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599413121; bh=YA6BXBaVAzMARXXVWIRzJEr/Ljjjo9xio4vkwKodA8I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=sjnGkLTCR6Y0y2yKCP8CFn0lh2eW8Z2g6rnEIGCieqrnNSmHfgzS72guUn20C9l/T lin1607wxYs/r33adn4eGx6hdCLy641obhtVANOEJvy4Fx2t2myR2oaujFp7B4eZ9w fdmqF4Q7hszKsuJAzTChe2ay2srw8SF/GMaFAh5M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729158AbgIFRZU (ORCPT ); Sun, 6 Sep 2020 13:25:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:59026 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725816AbgIFRZS (ORCPT ); Sun, 6 Sep 2020 13:25:18 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D84A220738; Sun, 6 Sep 2020 17:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599413118; bh=YA6BXBaVAzMARXXVWIRzJEr/Ljjjo9xio4vkwKodA8I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y1k/cLgtlwkbC5QtE7GzggDZx53kECoiysZ8zN9+CR4uJuf1NdhdyHbMmBJaAuvss kwK+kQ0mffaInUzSP4njgtYtKil7lyfsMkDWAOS7YbIAlLwvF58Dug3HUJeSRnParC SE/V1z7H+wEFEoTGpqCw1RKXUs3u2/LnYOJ1DyVw= Date: Sun, 6 Sep 2020 10:25:16 -0700 From: Jakub Kicinski To: Linus Walleij Cc: netdev@vger.kernel.org, "David S . Miller" , Hans Ulli Kroll , Andrew Lunn Subject: Re: [net-next PATCH v2] net: gemini: Clean up phy registration Message-ID: <20200906102516.5d1f4014@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200905204257.51044-1-linus.walleij@linaro.org> References: <20200905204257.51044-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 5 Sep 2020 22:42:57 +0200 Linus Walleij wrote: > diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c > index ffec0f3dd957..94707c9dda88 100644 > --- a/drivers/net/ethernet/cortina/gemini.c > +++ b/drivers/net/ethernet/cortina/gemini.c > @@ -2505,6 +2491,13 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev) > if (ret) > goto unprepare; > > + ret = gmac_setup_phy(netdev); > + if (ret) { > + netdev_err(netdev, > + "PHY init failed\n"); > + return ret; goto unprepare? > + } > + > ret = register_netdev(netdev); > if (ret) > goto unprepare;