Netdev Archive on
help / color / mirror / Atom feed
* Failing to attach bond(created with two interfaces from different NICs) to a bridge
@ 2020-09-03  7:22 Vasundhara Volam
  2020-09-03 19:14 ` Jakub Kicinski
  0 siblings, 1 reply; 9+ messages in thread
From: Vasundhara Volam @ 2020-09-03  7:22 UTC (permalink / raw)
  To: Jiri Pirko; +Cc: Michael Chan, jtoppins, Netdev

Hello Jiri,

After the following set of upstream commits, the user fails to attach
a bond to the bridge, if the user creates the bond with two interfaces
from different bnxt_en NICs. Previously bnxt_en driver does not
advertise the switch_id for legacy mode as part of
ndo_get_port_parent_id cb but with the following patches, switch_id is
returned even in legacy mode which is causing the failure.

7e1146e8c10c00f859843817da8ecc5d902ea409 net: devlink: introduce
devlink_compat_switch_id_get() helper
6605a226781eb1224c2dcf974a39eea11862b864 bnxt: pass switch ID through
56d9f4e8f70e6f47ad4da7640753cf95ae51a356 bnxt: remove
ndo_get_port_parent_id implementation for physical ports

As there is a plan to get rid of ndo_get_port_parent_id in future, I
think there is a need to fix devlink_compat_switch_id_get() to return
the switch_id only when device is in SWITCHDEV mode and this effects
all the NICs.

Please let me know your thoughts. Thank you.


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-09-08  6:24 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03  7:22 Failing to attach bond(created with two interfaces from different NICs) to a bridge Vasundhara Volam
2020-09-03 19:14 ` Jakub Kicinski
2020-09-06 11:12   ` Ido Schimmel
2020-09-06 17:13     ` Jakub Kicinski
2020-09-06 19:23       ` Florian Fainelli
2020-09-07  7:36         ` Ido Schimmel
2020-09-07 16:14           ` Jakub Kicinski
2020-09-08  6:24           ` Vasundhara Volam
2020-09-06 11:15   ` Vasundhara Volam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).